Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igx-grid memory leak when users click pagination buttons #13994

Closed
jsakamotoIGJP opened this issue Mar 18, 2024 · 5 comments
Closed

igx-grid memory leak when users click pagination buttons #13994

jsakamotoIGJP opened this issue Mar 18, 2024 · 5 comments

Comments

@jsakamotoIGJP
Copy link

Description

The igx-grid has a memory leaking problem. It happens when users click the paginator buttons.

  • igniteui-angular version: 17.1.4
  • browser: Microsoft Edge Version 122.0.2365.92 (Official Build) (64-bit)

Steps to reproduce

  1. Open the browser's Dev Tools / Memory tab.
  2. Take the 1st memory snapshot (don't forget to click the "Collect garbage" button before taking.)
  3. Navigate to the page with an igx-grid component with a pagenator.
  4. Click on the "next page" button of the pagenator.
  5. Go back to the home page.
  6. Take the 2nd memory snapshot (remember to click the "Collect garbage" button before taking it).
  7. In the Dev Tools Memory tab, Choose "Comparison" in the "Perspective" dropdown and input "igx" into the "Class filter" text field.
2024-03-18_16h39_26.mp4

Result

You will see there are some objects with the name "igx" that were added but not deleted in the "Comparison" view of the Memory tab.

Expected result

The "Delta" column for all objects with the name "igx" should be zero in the "Comparison" view of the Memory tab.

Attachments

📦c-00235192-ng-app1-v17.1.4 (2).zip

Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Jul 17, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 24, 2024
@ChronosSF ChronosSF reopened this Jul 24, 2024
@ChronosSF ChronosSF removed the status: inactive Used to stale issues and pull requests label Jul 24, 2024
@jsakamotoIGJP
Copy link
Author

Hi @ChronosSF, thank you for reopening this ticket!

Copy link

There has been no recent activity and this issue has been marked inactive.

@github-actions github-actions bot added the status: inactive Used to stale issues and pull requests label Sep 23, 2024
@ChronosSF ChronosSF added 👀 status: in-review Issue is currently being reviewed and removed status: inactive Used to stale issues and pull requests 🛠️ status: in-development Issues and PRs with active development on them labels Sep 24, 2024
@ChronosSF ChronosSF removed their assignment Sep 24, 2024
@MayaKirova MayaKirova self-assigned this Oct 14, 2024
@MayaKirova
Copy link
Contributor

@dkamburov @ChronosSF
Looking into this it seems like there are some detached nodes that get left on the page, such as the igx-grid node itself:

image

However that seems to be the case for any component where you have done any type of interaction (for example clicked on a button) and then destroy it.

I’ve modified the sample a bit here:
c-00235192-ng-app1-v17.1.4.2-modified.zip

I’ve added to the sample another page that loads a very simple component (app-component-test) with some text and a button, the button does nothing and the text is static. Still if you do the following:

  1. Do a baseline mem. profile
  2. Navigate to the new page (Go to test page 5)
  3. Click on the button
  4. Navigate back to home
  5. Do another mem.profile and compare them.

You’ll notice that the component’s DOM (app-component-test) remains in memory:
image

You can also find the content of the component as detached nodes.

That seems to be similar to an issue logged in angular: angular/angular#56477
That has then been closed as an upstream issue in Chrome:
https://issues.chromium.org/issues/40056157
https://issues.chromium.org/issues/41466808

I don't think there's anything we can do on our side for this.

@ChronosSF
Copy link
Member

Thank you for investigating this so thoroughly, @MayaKirova . I am closing this as a third-party-issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants