-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
igx-combo - improve accessibility for reading aloud by screen reader apps, especially the Windows Narrator #13622
Comments
The related issue is here: #13594 |
This is my workaround. This workaround patches the
The patch code that is doing above is below: export const igxComboItemsAriaPatch = () => {
const comboItems = Array.from(document.querySelector(".igx-combo__content").querySelectorAll("igx-combo-item"));
comboItems.forEach(item => {
item.ariaLabel = item.querySelector(".igx-drop-down__inner").textContent.trim();
item.querySelector("igx-checkbox").ariaHidden = "true";
});
} See also the video below that shows you the result of the workaround above. (By default, the following video might be muted. Please watch by turning off the mute.) video2-min.mp4Unfortunately, the Windows Narrator is also not perfect. The workaround above still sometimes doesn't work well. It is not stable. However, we should do our best to make it render higher accessibility, I think. |
There has been no recent activity and this issue has been marked inactive. |
There has been no recent activity and this issue has been marked inactive. |
Oh no, don't close this issue. The customer is waitng for fixing this issue for a long time. Please handle this. (CC: @Lipata ) |
Thank you, @Lipata ! |
There has been no recent activity and this issue has been marked inactive. |
Sorry for interrupt you, @Lipata, but could you keep this issue be opened? |
There has been no recent activity and this issue has been marked inactive. |
There has been no recent activity and this issue has been marked inactive. |
There has been no recent activity and this issue has been marked inactive. |
Hi @Lipata, I don't want to push you and your team, but personally, I feel like this feature request is not so hard to implement since it just adds some "aria—" attributes. Of course, I understand there might be some reasons not to start this improvement that I can't see. Or, if you and your team decide not to fix this issue, please let us know and explain your decision. In any case, we'd appreciate it if you would reconsider taking care of this issue. Thanks in advance. |
@jsakamotoIGJP, we will review the issue in the next sprint at the start of 2025. |
Thank you, @Lipata, for reopening this issue. Yeah, it is close to the end of the holiday season now, so I hope you and your team have a good time. See you again next year! |
Is your feature request related to a problem? Please describe.
Yes, it is.
When I enabled the Windows Narrator and operated a web page that has the
igx-combo
, the Narrator could not work as I expected.See also the video below. (By default, the following video might be muted. Please watch by turning off the mute.)
video1-min.mp4
Describe the solution you'd like
input type=checkbox
element.Describe alternatives you've considered
Patching the
aria-*
attributes of DOM elements that generated byigx-combo
at runtime.Additional context
This is the source project I used to investigate this issue:
📦c-00233265-ng-app.zip
The text was updated successfully, but these errors were encountered: