Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for some PivotGrid services #11030

Closed
9 tasks done
ChronosSF opened this issue Feb 16, 2022 · 0 comments · Fixed by #11185
Closed
9 tasks done

Increase test coverage for some PivotGrid services #11030

ChronosSF opened this issue Feb 16, 2022 · 0 comments · Fixed by #11185
Assignees
@dkamburov @ChronosSF @mddragnev
Labels
📈 enhancement grid: pivot 📔 ci: coverage ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@ChronosSF
Copy link
Member

ChronosSF commented Feb 16, 2022 •
edited by MayaKirova
Loading

The task includes the following files:

  • IgxPivotAggregate - @MayaKirova - unit tests
  • IgxPivotResizeHandleDirective - @mddragnev - onDoubleClick is not covered - probably a UI test
  • pivot-grid-navigation.service.ts - @mddragnev - some navigation options are missing, could be unit tested
  • pivot-resizing.service.ts - @mddragnev - max/min column widths are not covered
  • pivot-header-row.component.ts - filterRemoved and other functions
  • pivot-grid.component.ts - @mddragnev - generateFromData is completely missed, displayDensity too
  • pivot-row-dimension-header-group.component.ts - @mddragnev - activeGroup getter is missed
  • pivot-strategy - @mddragnev - try to pass getFieldValue through the formatAsDate flag
  • pivot-row-dimension-content.component.ts - @mddragnev - toggleDimension is not hit

You can refer to the whole coverage result: https://coveralls.io/builds/46594872
@mddragnev mddragnev mentioned this issue Mar 7, 2022
Merged
14 tasks
@mddragnev mddragnev self-assigned this Mar 7, 2022
@mddragnev mddragnev added 🛠️ status: in-development Issues and PRs with active development on them and removed 🆕 status: new labels Mar 8, 2022
@MayaKirova MayaKirova mentioned this issue Mar 16, 2022
Merged
14 tasks
@dkamburov dkamburov added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🛠️ status: in-development Issues and PRs with active development on them labels Mar 17, 2022
@dkamburov dkamburov mentioned this issue Mar 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkamburov dkamburov

@ChronosSF ChronosSF

@mddragnev mddragnev

Labels
📈 enhancement grid: pivot 📔 ci: coverage ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merging 13.1.x into master IgniteUI/igniteui-angular
3 participants
@dkamburov @ChronosSF @mddragnev