Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

igx-chip has a different background color #10481

Closed
kdinev opened this issue Nov 11, 2021 · 1 comment · Fixed by #10559
Closed

igx-chip has a different background color #10481

kdinev opened this issue Nov 11, 2021 · 1 comment · Fixed by #10559
Assignees
Labels
🐛 bug Any issue that describes a bug chip dark-theme severity: low ✨ themes version: 13.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.

Comments

@kdinev
Copy link
Member

kdinev commented Nov 11, 2021

Description

The igx-chip component looks different in 13.0 from 12.2. Note: to me the chip looks better, but if this is intentional, then it should be documented with an example of how to return its look and feel back to the old version.

  • igniteui-angular version: 13.0.0-alpha.7
  • browser: all

Steps to reproduce

  1. Create an angular view with an igx-chip.
  2. Define the following theme:
$primary: white !default;
$secondary: #FF0A3A !default;
$background: #192053;
$banner-background: #2C3D93;
$background-gradient: linear-gradient(to right, $background, #04081D);
$background-gradient-lighter: linear-gradient(135deg, #2f3978 0%, #10193f 100%);
$progress-success: #13FF21;

$app-palette: igx-palette($primary, $secondary);

@include igx-dark-theme(
  $palette: $app-palette
);

.igx-chip {
  margin: 4px 4px 4px 0;
}

Result

image

Note: chips that are not selected are pretty much unreadable:
image

Expected result

image

Attachments

Attach a sample if available, and screenshots, if applicable.

@kdinev
Copy link
Member Author

kdinev commented Nov 12, 2021

I got this resolved by adding $grays to my app-palette. However, the transparency is lost.

$primary: white;
$secondary: #FF0A3A;
$grays: white;

$app-palette: igx-palette($primary: $primary, $secondary: $secondary, $grays: $grays);

@include igx-palette-vars($app-palette);

@simeonoff simeonoff added ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged. and removed 🆕 status: new labels Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Any issue that describes a bug chip dark-theme severity: low ✨ themes version: 13.0.x ✅ status: resolved Applies to issues that have pending PRs resolving them, or PRs that have already merged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants