diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 0adf22bcaea..108bc26424f 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -1,5 +1,5 @@ # Overview -Ignite UI JS Blocks version accepts contributions, as long as they follow the guidelines explained below. When contributing you would have to follow these steps: +Ignite UI for Angular version accepts contributions, as long as they follow the guidelines explained below. When contributing you would have to follow these steps: 1. Fork the repository 2. Perform the changes in your fork @@ -16,13 +16,13 @@ In order to perform all the necessary checks before pulling your changes in, you [CSS Naming Convention](https://github.com/IgniteUI/igniteui-angular/blob/master/css-naming-convention.md) # Workflow -When working on an issue for the Ignite UI JS Blocks repository, you need to be aware of and to follow a correct status workflow. We have created a number of status labels in order to communicate well what the current status of a single issue/pull request is. The statuses are as follows: +When working on an issue for the Ignite UI for Angular repository, you need to be aware of and to follow a correct status workflow. We have created a number of status labels in order to communicate well what the current status of a single issue/pull request is. The statuses are as follows: ## Development - applicable to issues and pull requests 1. `status: in-review` this is the initial status of an issue. If the label is not placed, go ahead and place it. 2. `status: in-development` this is the status once you start working on an issue. Assign the issue to yourself if it hasn't been assigned already and remove the previous status and assign it an in development status. 3. `status: by-design` this is the status of an issue that has been reviewed and has been determined that the current design of the feature is such that the issue describes the correct behavior as incorrect. Remove other statuses and place this status if you've reviewed the issue. -4. `status: third-party-issue` this is the status of an issue that has been reviewed, has been determined to be an issue, but the root case is not in the Ignite UI JS Blocks code. Example would be browser specific bugs caused by the particular browser's rendering or JavaScript engines, or an issue with the Angular framework. Remove other statuses and place only this one if you're the one performing the investigation. +4. `status: third-party-issue` this is the status of an issue that has been reviewed, has been determined to be an issue, but the root case is not in the Ignite UI for Angular code. Example would be browser specific bugs caused by the particular browser's rendering or JavaScript engines, or an issue with the Angular framework. Remove other statuses and place only this one if you're the one performing the investigation. 5. `status: not-to-fix` this is the status of issues that derive from our code, but have been decided to leave as is. This is done when fixes require general design and/or architecture changes and are very risky. ## Testing - applicable to pull requests diff --git a/css-naming-convention.md b/css-naming-convention.md index 0165e208bc7..ba9df136bca 100644 --- a/css-naming-convention.md +++ b/css-naming-convention.md @@ -1,6 +1,6 @@ -# Ignite UI JS Blocks CSS Naming Convention +# Ignite UI for Angular CSS Naming Convention -Ignite UI JS Blocks uses the Two Dashes style of the [BEM naming convention](https://en.bem.info/methodology/naming-convention/) for CSS classes. +Ignite UI for Angular uses the Two Dashes style of the [BEM naming convention](https://en.bem.info/methodology/naming-convention/) for CSS classes. Naming Convention: diff --git a/demos/app/app.component.html b/demos/app/app.component.html index 99f2f781d75..51101daed8e 100644 --- a/demos/app/app.component.html +++ b/demos/app/app.component.html @@ -3,7 +3,7 @@ [(pin)]="drawerState.pin" [width]="drawerState.width" [position]="drawerState.position">