Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immersive start page, no Wolvic UI shown #1279

Closed
Utopiah opened this issue Mar 1, 2024 · 7 comments · Fixed by #1171
Closed

Immersive start page, no Wolvic UI shown #1279

Utopiah opened this issue Mar 1, 2024 · 7 comments · Fixed by #1171
Labels
enhancement New feature or request

Comments

@Utopiah
Copy link

Utopiah commented Mar 1, 2024

Is your feature request related to a problem? Please describe.
I do no program natively but solely on the Web, mostly WebXR. I want to skip the OS UI to go straight to Wolvic. From there I can have a start page

Describe the solution you'd like
Supporting it at all (if that's not already the case), then allowing it via setting option, if not as a command line option

Describe alternatives you've considered

Additional context

@svillar
Copy link
Member

svillar commented Mar 1, 2024

Duplicate of #1211 ?

@svillar svillar added the enhancement New feature or request label Mar 1, 2024
@Utopiah
Copy link
Author

Utopiah commented Mar 1, 2024

Does #1211 concerns the start page or even opening via an adb command/intent?

My point being not of open Wolvic then navigating to an immersive WebXR page then opening it in XR (which I believe that other issue is about) but rather starting Wolvic and have e.g https://aframe.io/aframe/examples/boilerplate/hello-world/ directly in VR.

@svillar
Copy link
Member

svillar commented Mar 1, 2024

Does #1211 concerns the start page or even opening via an adb command/intent?

My point being not of open Wolvic then navigating to an immersive WebXR page then opening it in XR (which I believe that other issue is about) but rather starting Wolvic and have e.g https://aframe.io/aframe/examples/boilerplate/hello-world/ directly in VR.

Then you're talking about #1171

@Utopiah
Copy link
Author

Utopiah commented Mar 1, 2024

#1171 provides a very interesting way to solve this indeed without touching much the code itself through the extension. I believe this is such a rare use case (for now) that instead of having the browser UI modified itself, just parameters is enough. Thanks for pointing it out!

So in my example @felipeerias would it mean

adb shell am start -n "com.igalia.wolvic/com.igalia.wolvic.VRBrowserActivity" \
    -a android.intent.action.MAIN                                             \
    -c android.intent.category.LAUNCHER                                       \
    -a android.intent.action.VIEW                                             \
    -d "https://aframe.io/aframe/examples/boilerplate/hello-world/"           \
    --ez open_in_immersive true                                               \
    --ez hide_webxr_interstitial true                                         \
    -e open_in_immersive_parent_xpath ''                                      \
    -e open_in_immersive_element_xpath '/html/body/a-scene/div[2]/button'

?

Finally @svillar do you imagine this PR would be reviewed soon? I have it in mind for #1103 but as I'm building myself for now I could just pull-in this patch.

@svillar
Copy link
Member

svillar commented Mar 6, 2024

Finally @svillar do you imagine this PR would be reviewed soon? I have it in mind for #1103 but as I'm building myself for now I could just pull-in this patch.

Sure, somehow it got its way in the middle of my work pile and didn't have a chance to get my attention. I'll review it sooner than later

@svillar
Copy link
Member

svillar commented Mar 15, 2024

Then I think this could be the same as #735 ?

@LAGENCECREE
Copy link

partially 🧐

@svillar svillar linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants