Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Fixes #487 - Name of the session cookie is derived from EffeciveAuthenticationScheme #502

Merged
merged 2 commits into from
Nov 29, 2016

Conversation

schatekar
Copy link
Contributor

@schatekar schatekar commented Nov 24, 2016

Deriving name of the session cookie from EffectiveAuthenitcationScheme makes it configurable.

I have run all the unit tests locally and they pass. I do not know how to run integration tests locally. Appreciate if someone can help with that.

…iveAuthenticationScheme which makes it configurable
@dnfclas
Copy link

dnfclas commented Nov 24, 2016

Hi @schatekar, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@schatekar
Copy link
Contributor Author

I think I know what's causing this to fail. On it now.

…ookie name as the actual code is now using
@leastprivilege leastprivilege added this to the RC4 milestone Nov 24, 2016
@brockallen brockallen merged commit f892a24 into IdentityServer:dev Nov 29, 2016
@brockallen
Copy link
Member

Thanks!

@schatekar schatekar deleted the issue-487 branch November 30, 2016 09:34
@lock
Copy link

lock bot commented Jan 11, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants