Invalid log message in TokenRequestValidator

[strtdusty]

• [x ] I read and understood how to enable logging

Issue / Steps to reproduce the problem

If an authZCode.ClientID (XXXX) does not match the requested clientID (YYYY), the log message shows:
Client XXX is trying to use a code from client XXX

Current Code (line 203):
LogError("Client {clientId} is trying to use a code from client {clientId}", _validatedRequest.Client.ClientId, authZcode.ClientId);

Proposed Code:
LogError("Client {0} is trying to use a code from client {1}", _validatedRequest.Client.ClientId, authZcode.ClientId);

The log is obviously getting confused about which client ID to use.

[leastprivilege]

PR?

[strtdusty]

Happy to create a PR. How do I get permission to push a PR branch up? I can sign the https://cla.dotnetfoundation.org/ form but there is no IS4 project to select.

[leastprivilege]

Oh - thanks for making me aware of that - the project name is wrong - you need to choose "Thinktecture.IdentityServer".

Just start with the PR - the rest will be taken care of by the "CLA Bot"

[initialspark]

This looks like it will happen on line 512 as well.

LogError("{clientId} tries to refresh token belonging to {clientId}", _validatedRequest.Client.ClientId,
refreshToken.ClientId);

So it might be worth updating your pull request with this one too.

[strtdusty]

@initialspark Good catch. Updated the PR

[brockallen]

merged, thanks.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.