Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Consider expose PersistentGrantSerializer as interface #624

Closed
sbebrys opened this issue Dec 21, 2016 · 6 comments
Closed

Consider expose PersistentGrantSerializer as interface #624

sbebrys opened this issue Dec 21, 2016 · 6 comments
Assignees
@brockallen
Labels
enhancement
Milestone
RTM

Comments

@sbebrys
Copy link

sbebrys commented Dec 21, 2016 •
edited
Loading

Consider expose PersistentGrantSerializer as interface to make own implementation without extend this class. It would be easier to use own internal serializer instead JsonConvert.
@brockallen
Copy link
Member

I'm curious what you need/want to do differently for your serialization?

@brockallen brockallen added this to the RTM milestone Dec 22, 2016
@brockallen
Copy link
Member

look ok? df62c4a

@brockallen
Copy link
Member

@leastprivilege any objections?

@brockallen
Copy link
Member

merged.

@sbebrys
Copy link
Author

sbebrys commented Dec 22, 2016

JsonConvert it isn't the fastest way to serialize these objects - profiler showed big hot path in this place - so now I could make something more optimal :)

@lock
Copy link

lock bot commented Jan 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brockallen brockallen

Labels
enhancement
Projects
None yet
Milestone
RTM
Development

No branches or pull requests
3 participants
@brockallen @leastprivilege @sbebrys