Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Typo in DefaultClaimsService.cs #4929

Closed
tndata opened this issue Sep 30, 2020 · 2 comments
Closed

Typo in DefaultClaimsService.cs #4929

tndata opened this issue Sep 30, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@tndata
Copy link

tndata commented Sep 30, 2020

In the file

IdentityServer4/src/IdentityServer4/src/Services/Default/DefaultClaimsService.cs

The XML documentation for the GetAccessTokenClaimsAsync method is wrong. Replace Identity with access.

    /// <summary>
    /// Returns claims for an **identity** token.
    /// </summary>
    /// <param name="subject">The subject.</param>
    /// <param name="resourceResult">The validated resource result</param>
    /// <param name="request">The raw request.</param>
    /// <returns>
    /// Claims for the access token
    /// </returns>
    public virtual async Task<IEnumerable<Claim>> GetAccessTokenClaimsAsync(ClaimsPrincipal subject, ResourceValidationResult resourceResult, ValidatedRequest request)
    {
@leastprivilege leastprivilege self-assigned this Sep 30, 2020
@leastprivilege leastprivilege added this to the 4.1.1 milestone Sep 30, 2020
@brockallen brockallen added bug and removed bug report labels Oct 2, 2020
@brockallen
Copy link
Member

Fixed. I meant to do a PR, but I accidentally just did it directly on main.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants