Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Create integration tests for PKCE #183

Closed
leastprivilege opened this issue Jul 27, 2016 · 6 comments
Closed

Create integration tests for PKCE #183

leastprivilege opened this issue Jul 27, 2016 · 6 comments
Assignees
@brockallen
Labels
enhancement
Milestone
RC1

Comments

@leastprivilege
Copy link
Member

spanning authorize and token endpoints
@leastprivilege leastprivilege added this to the RC1 milestone Jul 27, 2016
@brockallen
Copy link
Member

i ported the ones from idsv3 and pushed to dev. there are a few that have some issues we need to discuss.

@brockallen
Copy link
Member

Perhaps we should discuss setting the default response_mode as soon as the response_type is determined. This will solve the chicken & egg problem we're seeing.

@brockallen
Copy link
Member

Not the most elegant PR ever, but this encapsulates all the changes needed to make this work. The main things are:

  • allow error_description into authorization responses
  • move assignment of the default response_mode earlier (as soon as response_type is known)

#207

@brockallen
Copy link
Member

merged. 2 tests marked as skip pending updates to IdModel

@leastprivilege
Copy link
Member Author

updated idm and tests

@lock
Copy link

lock bot commented Jan 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@brockallen brockallen

Labels
enhancement
Projects
None yet
Milestone
RC1
Development

No branches or pull requests
2 participants
@brockallen @leastprivilege