Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Edit on GitHub link leads to 404 #1714

Closed
SIkebe opened this issue Nov 7, 2017 · 6 comments
Closed

Edit on GitHub link leads to 404 #1714

SIkebe opened this issue Nov 7, 2017 · 6 comments
Labels

Comments

@SIkebe
Copy link
Contributor

SIkebe commented Nov 7, 2017

Hi! I realized any Edit on GitHub link in docs redirects to 404.
Any path changed or a sphinx issue like this?

For now IdentityServer4 docs is using sphinx 1.0.

# needs_sphinx = '1.0'

@leastprivilege
Copy link
Member

I noticed that as well - the "origin" is not right in the generated link.

Do you have experience with Sphinx? If yes - you can do a PR on the conf.py.

@SIkebe
Copy link
Contributor Author

SIkebe commented Nov 7, 2017

@leastprivilege Unfortunately no.
I ran make.bat html locally but generated html shows "View page source" not "Edit on GitHub".

@leastprivilege
Copy link
Member

seems to be a known issue

readthedocs/readthedocs.org#3203

@brockallen
Copy link
Member

Update: There's a PR pending to fix this.

@leastprivilege
Copy link
Member

it's fixed

@lock
Copy link

lock bot commented Jan 13, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants