Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

Default client scopes #161

Closed
JonCubed opened this issue Jul 18, 2016 · 11 comments
Closed

Default client scopes #161

JonCubed opened this issue Jul 18, 2016 · 11 comments
Assignees
Milestone

Comments

@JonCubed
Copy link

JonCubed commented Jul 18, 2016

I'm porting our custom oauth implementation to identity server 4. Currently all our services have their own list of clients, I would like to merge them all into identity server instead with scopes. Currently third-parties are not sending the scope header, however in identity server 4 this returns a bad request with "invalid_scope".

I've looked at the code and it does not look like this scenario is possible. Would it be possible to be able to specify default scopes for a client so if the scope header is not present it will not fail?

From my understanding of the spec a predefined list of default scopes is allowed if the scope header is missing.

@leastprivilege
Copy link
Member

We have no plans right now to change that. Tbh - there are other priorities right now to be able to ship 1.0

But I added this as a feature request.

@JonCubed
Copy link
Author

ok, any chance you'd be open to pull request to add this before 1.0?

@leastprivilege
Copy link
Member

we will discuss it.

@leastprivilege leastprivilege self-assigned this Jul 19, 2016
@JonCubed
Copy link
Author

thanks @leastprivilege

@brockallen
Copy link
Member

Perhaps if scopes are absent, we just use the list of configured allowed scopes...

@brockallen
Copy link
Member

brockallen commented Aug 27, 2016

@JonCubed What flows are your third parties using?

@brockallen brockallen removed their assignment Aug 27, 2016
@JonCubed
Copy link
Author

JonCubed commented Aug 29, 2016

@brockallen they are using Client Credentials

@leastprivilege
Copy link
Member

OK - I'll add that feature for client credentials.

@leastprivilege
Copy link
Member

see here

#241

does that work for you?

@JonCubed
Copy link
Author

JonCubed commented Sep 1, 2016

@brockallen yes it does, thank you very much for getting done so quickly

@lock
Copy link

lock bot commented Jan 15, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants