Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated imp module with importlib #904

Closed
hugovk opened this issue Apr 29, 2023 · 2 comments
Closed

Replace deprecated imp module with importlib #904

hugovk opened this issue Apr 29, 2023 · 2 comments
Labels
dependency good first issue next-release should become part of the next release

Comments

@hugovk
Copy link

hugovk commented Apr 29, 2023

Code Version

master

Expected Behavior

Works with Python 3.12.

Current Behavior

This project uses the imp module which has been deprecated since Python 3.4 and removed in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Possible Solution

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

Steps to Reproduce

  1. git grep "\bimp\b"
@hugovk hugovk mentioned this issue May 3, 2023
Open
31 tasks
@c00kiemon5ter
Copy link
Member

Hello and thanks for the report. We will fix this asap.

The only occurrence is at src/saml2/tools/parse_xsd2.py - should be reasonably easy to change to importlib.

@c00kiemon5ter c00kiemon5ter added good first issue next-release should become part of the next release dependency labels Nov 7, 2023
@c00kiemon5ter
Copy link
Member

Fixed by 116d843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependency good first issue next-release should become part of the next release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c00kiemon5ter @hugovk