Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving README #44

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Improving README #44

merged 1 commit into from
Jan 17, 2017

Conversation

lazyfrosch
Copy link
Contributor

Some formatting, typos, Puppet style

Some formatting, typos, Puppet style
@lazyfrosch lazyfrosch requested a review from bobapple January 16, 2017 16:49
This module installs and configures Icinga 2 on your Linux or Windows hosts

By default it will use packages provided by your distributions repository, respectively
[Chocolatey] on Windows.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a link missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, linked on bottom :)

as primary repository, which will give you the ability to install the latest Icinga 2 release. All features and objects
available in Icinga 2 can be enabled and configured with this module.

This module installs and configures Icinga 2 on your Linux or Windows hosts

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dot at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update the branch yourself anytime :)

* A client node which works as an agent connected to master and/or satellite nodes.
* in a master zone which is on top of the hierarchy
* in a satellite zone which is a child of a satellite or master zone
* a standalone client node/zone which works as an agent connected to master and/or satellite zones

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First character must be capitalised, line ends with dots.

Ths examples creates the configuration for a Master that has one Satellite connected. A global zone is created for
templates and all features of a typical master are enabled.
Ths examples creates the configuration for a master that has one satellite connected. A global zone is created for
templates, and all features of a typical master are enabled.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This example creates".

@lazyfrosch
Copy link
Contributor Author

You can update the branch yourself anytime :)

@bobapple bobapple merged commit 19eab2f into master Jan 17, 2017
@bobapple bobapple deleted the feature/better-readme branch January 17, 2017 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants