Don't call private method preferred_run_mode= in facts #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method preferred_run_mode= is private and should not be called externally, especially not in custom facts. Doing so breaks a Puppet master in interesting ways and is entirely unnecessary. Providing Puppet settings as facts works fine when simply requiring 'puppet' instead of 'facter'.
|
Merged, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method preferred_run_mode= is private and should not be called
externally, especially not in custom facts. Doing so breaks a Puppet
master in interesting ways and is entirely unnecessary.
Providing Puppet settings as facts works fine when simply requiring
'puppet' instead of 'facter'.