Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inverted check for HA cluster #9283

Open
julianbrost opened this issue Mar 9, 2022 · 1 comment
Open

Inverted check for HA cluster #9283

julianbrost opened this issue Mar 9, 2022 · 1 comment
Labels
area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working TBD To be defined - We aren't certain about this yet

Comments

@julianbrost
Copy link
Contributor

I mean the following just looks like it's the wrong way around:

bool ApiListener::IsHACluster()
{
Zone::Ptr zone = Zone::GetLocalZone();
if (!zone)
return false;
return zone->IsSingleInstance();
}

Maybe fix it, maybe have a look if code that uses it is even needed as the check was wrong all the time.

@julianbrost
Copy link
Contributor Author

Wait a second... that could actually explain #9265 as this function is used in a check that would delay notifications on failover:

if (ApiListener::IsHACluster() && GetNextNotification() < Utility::GetTime() + 60)
SetNextNotification(Utility::GetTime() + 60, true);

@Al2Klimov Al2Klimov added area/distributed Distributed monitoring (master, satellites, clients) TBD To be defined - We aren't certain about this yet labels Mar 22, 2022
@Al2Klimov Al2Klimov added the bug Something isn't working label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/distributed Distributed monitoring (master, satellites, clients) bug Something isn't working TBD To be defined - We aren't certain about this yet
Projects
None yet
Development

No branches or pull requests

2 participants