Fix: Pagefile provider returning values in MB instead of Bytes #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordHepipud
force-pushed
the
fix/pagefile_base_values_stored_as_mb_instead_of_bytes
branch
from
2f2447f
to
9e07cfc
Compare
LordHepipud
deleted the
fix/pagefile_base_values_stored_as_mb_instead_of_bytes
branch
atj
added a commit
to transitiv/icinga-powershell-plugins
that referenced
this pull request
Aug 9, 2023
The unit for pagefile attributes was changed from megabytes to bytes in IcingaGH-346 but the call to New-IcingaCheck was not updated to reflect this. Fixes Icinga#360.
This was referenced Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the pagefile provider at
Get-IcingaMemoryPerformanceCounterwhich returned the pagefile size in MB instead of BytesFixes Icinga/icinga-powershell-framework#617