Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoke-IcingaCheckUpdates - improvements #143

Closed
jcharaoui opened this issue Mar 10, 2021 · 6 comments · Fixed by #264
Closed

Invoke-IcingaCheckUpdates - improvements #143

jcharaoui opened this issue Mar 10, 2021 · 6 comments · Fixed by #264
Assignees
Labels
enhancement New feature or request question Further information is requested
Milestone

Comments

@jcharaoui
Copy link

Currently the -Filter option allows the plugin to limit considered updates to certain predefined criteria. However, it's not possible to do the reverse: only exclude matching updates, and consider all others.

In this instance, I would like to only exclude updates that match Security Intelligence Update, since those a published very frequently, and consider all other possible updates.

@LordHepipud LordHepipud self-assigned this Mar 10, 2021
@LordHepipud LordHepipud added enhancement New feature or request question Further information is requested labels Mar 10, 2021
@LordHepipud LordHepipud added this to the v1.5.0 milestone Mar 10, 2021
@LordHepipud
Copy link
Collaborator

Yeah this is a great idea and wanted to improve the filtering a lot already. Could we use this issue to collect some feedback on what everyone would be looking for on Windows updates?

The more input we get, the more we can improve on how results are handled and which updates are pending.

@jcharaoui jcharaoui changed the title Invoke-IcingaCheckUpdates - missing an option to exclude certain updates Invoke-IcingaCheckUpdates - improvements Mar 10, 2021
@jcharaoui
Copy link
Author

An option to list the names of the updates in the result output.

@jcharaoui
Copy link
Author

Options to filter or exclude certain update categories. For example, Windows Defender definition updates have a Categories property which contain Definition Updates. The plugin should be able to ignore those.

Another use-case for this is to consider only security-related updates.

@jcharaoui
Copy link
Author

Also, I'm not sure if this issue is specific to the plugin, if it's by design, or if there's an off-by-one error somewhere:

When I specify the -Warning 1 the plugin only warns if there are more than one updates pending, instead of one or more. I work with a lot of Icinga2 plugins and it seems its the only one with this interpretation of a threshold.

@LordHepipud
Copy link
Collaborator

Thank you for all the input so far!

Regarding the thresholds, this is by design as we follow the Nagios/Icinga Plugin threshold guidelines: https://icinga.com/docs/icinga-for-windows/latest/plugins/doc/10-Icinga-Plugins/

Most of Icinga for Windows Plugins will follow these patterns and possibilities. The ones who don't are using direct matches for inputs or values not really compareable.

@jcharaoui
Copy link
Author

Regarding the thresholds, this is by design as we follow the Nagios/Icinga Plugin threshold guidelines: https://icinga.com/docs/icinga-for-windows/latest/plugins/doc/10-Icinga-Plugins/

Alright, thanks for the clarification on that point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants