Fix: Encoding problems with special chars or German umlauts #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordHepipud
force-pushed
the
fix/utf8_encoding_errors
branch
from
f3e27f0 to
493dcbd
Compare
This was referenced Feb 16, 2022
LordHepipud
force-pushed
the
fix/utf8_encoding_errors
branch
2 times, most recently
from
37b7993 to
eaf04f6
Compare
LordHepipud
force-pushed
the
fix/utf8_encoding_errors
branch
from
eaf04f6 to
813a362
Compare
LordHepipud
force-pushed
the
fix/utf8_encoding_errors
branch
from
813a362 to
787500c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Icinga for Windows plugin execution, by converting all parsed arguments and values from Icinga 2 from the
Defaultof the PowerShell toUTF8.This resolves issues during plugin execution on which arguments like
-Path,-TaskNameor anything else contained characters likeäöüß.In addition, we created an internal
StringBuilderto resolve current issues on which unescaped strings within the Icinga configuration likeIcinga for Windowsinstead of'Icinga for Windows', are interpreted asIcingainstead ofIcinga for Windowsbecause of the whitespaces.The new argument parser will test for this and create a proper string output value.