Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support check_multi output for performance data #485

Closed
LordHepipud opened this issue Feb 17, 2022 · 0 comments · Fixed by #526
Closed

Feature: Support check_multi output for performance data #485

LordHepipud opened this issue Feb 17, 2022 · 0 comments · Fixed by #526
Assignees
Labels
Enhancement New feature or request
Milestone

Comments

@LordHepipud
Copy link
Collaborator

We should update the PerfData write for Icinga for Windows to output performance data as check_multi output, allowing easier integration within graphing solutions.

This is dynamically not really parseable by solutions:

Invoke-IcingaCheckProcess -Process msedge
[OK] Process Overview: 1 Ok
| 'msedge_process_count'=42c;; 'msedge_page_file_usage'=5424752B;;;0;9728 'msedge_cpu_usage'=0%;;;0;100 'msedge_thread_count'=802c;; 'msedge_memory_usage'=4178043000B;;;0;68636310000

A better approach would be, to use check_multi format for this:

Invoke-IcingaCheckProcess -Process msedge
[OK] Process Overview: 1 Ok
| 'msedge::CheckProcess::process_count'=42c;; 'msedge::CheckProcess::page_file_usage'=5424752B;;;0;9728 'msedge::CheckProcess::cpu_usage'=0%;;;0;100 'msedge::CheckProcess::thread_count'=802c;; 'msedge::CheckProcess::memory_usage'=4178043000B;;;0;68636310000

By doing so, we can select the current process for example, choose the CheckProcess template and receive the proper label for displaying graphs.

We do however require some sort of flag to ensure users can switch between the current PerfData writer and the new version.

@LordHepipud LordHepipud added the Enhancement New feature or request label Feb 17, 2022
@LordHepipud LordHepipud added this to the v1.9.0 milestone Feb 17, 2022
@LordHepipud LordHepipud self-assigned this Feb 17, 2022
@LordHepipud LordHepipud modified the milestones: v1.9.0, v1.10.0 May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant