chore: improve code quality (#171)

IceWhaleTech · Mar 20, 2024 · 4084046 · 4084046
1 parent 7b060cd
commit 4084046
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/service/appstore.go b/service/appstore.go
@@ -61,9 +61,6 @@ func (s *appStore) CategoryMap() (map[string]codegen.CategoryInfo, error) {
 	}
 
 	categoryMap := LoadCategoryMap(storeRoot)
-	if err != nil {
-		return nil, err
-	}
 
 	s.categoryMap = categoryMap
 

diff --git a/service/appstore_management.go b/service/appstore_management.go
@@ -91,7 +91,7 @@ func (a *AppStoreManagement) DeleteGlobal(key string) error {
 func (a *AppStoreManagement) RegisterAppStore(ctx context.Context, appstoreURL string, callbacks ...func(*codegen.AppStoreMetadata)) error {
 	// check if appstore already exists
 	for _, url := range config.ServerInfo.AppStoreList {
-		if strings.ToLower(url) == strings.ToLower(appstoreURL) {
+		if strings.EqualFold(url, appstoreURL) {
 			return nil
 		}
 	}

diff --git a/service/compose_app.go b/service/compose_app.go
@@ -94,11 +94,10 @@ func (a *ComposeApp) AuthorType() codegen.StoreAppAuthorType {
 		return codegen.Unknown
 	}
 
-	if strings.ToLower(storeInfo.Author) == strings.ToLower(storeInfo.Developer) {
+	if strings.EqualFold(storeInfo.Author, storeInfo.Developer) {
 		return codegen.Official
 	}
-
-	if strings.ToLower(storeInfo.Author) == strings.ToLower(common.ComposeAppAuthorCasaOSTeam) {
+	if strings.EqualFold(storeInfo.Author, common.ComposeAppAuthorCasaOSTeam) {
 		return codegen.ByCasaos
 	}