🐛 make logstreaming callback safer

[bisgaard-itis]

What do these changes do?

• Improve exception handling in logstreaming callback
• Log exceptions raised by safe_nack in rabbitmq client

Related issue/s

• fixes Improve logstreaming callback and error handling of logstreaming in api-server #5629

How to test

cd services/api-server/tests/unit && python -m pytest -k test_log_streamer_not_raise_with_distributor

Dev-ops checklist

• No ENV changes or I properly updated ENV (read the instruction)

[codecov]

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.3%. Comparing base (cafbf96) to head (ba01ea5).
Report is 87 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #5633      +/-   ##
=========================================
+ Coverage    84.5%   87.3%    +2.7%     
=========================================
  Files          10    1071    +1061     
  Lines         214   46775   +46561     
  Branches       25     650     +625     
=========================================
+ Hits          181   40836   +40655     
- Misses         23    5789    +5766     
- Partials       10     150     +140     

Flag	Coverage Δ
integrationtests	65.1% <ø> (?)
unittests	84.8% <94.1%> (+0.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...service-library/src/servicelib/rabbitmq/_client.py	100.0% <100.0%> (ø)
...mcore_service_api_server/services/log_streaming.py	94.3% <92.3%> (ø)

... and 1072 files with indirect coverage changes

[sanderegg]

thanks!

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud