-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ subscribe to socketio room based on the user_id #5270
✨ subscribe to socketio room based on the user_id #5270
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5270 +/- ##
=========================================
+ Coverage 84.0% 85.1% +1.1%
=========================================
Files 636 1088 +452
Lines 30235 47740 +17505
Branches 607 551 -56
=========================================
+ Hits 25409 40655 +15246
- Misses 4684 6971 +2287
+ Partials 142 114 -28
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ee18e67
to
a1e657c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
packages/models-library/src/models_library/api_schemas_webserver/socketio.py
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What do these changes do?
Allows an easier way to send socketio messages via
user_id
.webserver
also subscribes to socketio rooms usinguser_id
🐛 socketio room entering is now properly awaitedAsyncServer.enter_room() is not awaitable miguelgrinberg/python-socketio#1256Related issue/s
How to test
Dev Checklist
DevOps Checklist