Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ subscribe to socketio room based on the user_id #5270

Merged

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Jan 25, 2024

What do these changes do?

Allows an easier way to send socketio messages via user_id.

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@GitHK GitHK self-assigned this Jan 25, 2024
@GitHK GitHK added this to the This is Sparta! milestone Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3c18555) 84.0% compared to head (a2c35db) 85.1%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5270      +/-   ##
=========================================
+ Coverage    84.0%   85.1%    +1.1%     
=========================================
  Files         636    1088     +452     
  Lines       30235   47740   +17505     
  Branches      607     551      -56     
=========================================
+ Hits        25409   40655   +15246     
- Misses       4684    6971    +2287     
+ Partials      142     114      -28     
Flag Coverage Δ
integrationtests ?
unittests 85.1% <92.0%> (+3.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/models_library/api_schemas_webserver/socketio.py 100.0% <100.0%> (ø)
.../src/simcore_service_payments/services/notifier.py 89.7% <100.0%> (ø)
...rc/simcore_service_webserver/socketio/_handlers.py 85.5% <100.0%> (+0.3%) ⬆️
...src/simcore_service_webserver/socketio/messages.py 100.0% <100.0%> (+5.7%) ⬆️
...tifications/_rabbitmq_exclusive_queue_consumers.py 64.7% <66.6%> (-21.0%) ⬇️
...simcore_service_webserver/projects/projects_api.py 77.5% <66.6%> (-6.9%) ⬇️

... and 790 files with indirect coverage changes

@GitHK GitHK force-pushed the pr-osparc-subscribe-socketio-to-user-id branch from ee18e67 to a1e657c Compare January 25, 2024 14:04
@GitHK GitHK marked this pull request as ready for review January 25, 2024 15:03
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@GitHK GitHK enabled auto-merge (squash) January 25, 2024 16:39
@GitHK GitHK merged commit 3693767 into ITISFoundation:master Jan 26, 2024
54 of 55 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants