✨ added CLUSTERS_KEEPER_EC2_INSTANCES_PREFIX env to facilitate testing (⚠️ devops) #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
a:infra+ops
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5251 +/- ##
=========================================
+ Coverage 87.3% 88.4% +1.0%
=========================================
Files 1302 897 -405
Lines 53225 39092 -14133
Branches 1168 583 -585
=========================================
- Hits 46484 34566 -11918
+ Misses 6491 4404 -2087
+ Partials 250 122 -128
Flags with carried forward coverage won't be shown. Click here to find out more. |
matusdrobuliak66
approved these changes
Jan 18, 2024
GitHK
approved these changes
Jan 18, 2024
pcrespov
approved these changes
Jan 18, 2024
services/clusters-keeper/src/simcore_service_clusters_keeper/core/settings.py
Outdated
Show resolved
Hide resolved
|
sanderegg
changed the title
sanderegg
deleted the
comp-backend/enhancement/add-cluster-name-prefix
branch
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This adds
CLUSTERS_KEEPER_EC2_INSTANCES_PREFIXto facilitate testing, and maybe later adding the option to specifically name clusters in different deployments.This allows to name external machines with a prefix, which is extremely useful when testing so to not mangle with other deploys.
Related issue/s
How to test
Dev Checklist
DevOps Checklist