Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Computational backend: add helpful tracing log #5218

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Jan 9, 2024

What do these changes do?

This PR adds some tracing logs that might prove useful when looking at computational jobs after they were run and the cluster was terminated.

Bonus:

  • adds retry mechanism in e2e playwright tests to retry giving access to services

Related issue/s

How to test

Dev Checklist

DevOps Checklist

@sanderegg sanderegg added the a:dask-service Any of the dask services: dask-scheduler/sidecar or worker label Jan 9, 2024
@sanderegg sanderegg added this to the a milestone with no name milestone Jan 9, 2024
@sanderegg sanderegg self-assigned this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (52e3fda) 85.6% compared to head (63379ba) 61.4%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5218      +/-   ##
=========================================
- Coverage    85.6%   61.4%   -24.2%     
=========================================
  Files        1292     546     -746     
  Lines       52992   27621   -25371     
  Branches     1160     202     -958     
=========================================
- Hits        45376   16976   -28400     
- Misses       7366   10595    +3229     
+ Partials      250      50     -200     
Flag Coverage Δ
integrationtests 60.6% <ø> (-4.3%) ⬇️
unittests 91.5% <100.0%> (+6.4%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...service_dask_sidecar/computational_sidecar/core.py 100.0% <100.0%> (ø)

... and 1048 files with indirect coverage changes

Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sanderegg sanderegg merged commit 744ff06 into ITISFoundation:master Jan 9, 2024
53 of 55 checks passed
@sanderegg sanderegg deleted the comp-backend/add-tracing-of-parents branch January 9, 2024 09:41
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Feb 14, 2024
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:dask-service Any of the dask services: dask-scheduler/sidecar or worker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants