🐛Prevent autoscaling from creating workers indefinitely

[sanderegg]

What do these changes do?

• drained node instance resources were computed using docker facilities instead of EC2, thus leading to an infinite creation of EC2 instance.

Bonus

• fixes time to terminate
• shows logs before terminating in info
• adds a pre-commit hook to check for pytest.mark.testit

Related issue/s

• fixes Autoscaling: creates new machines although the current one should be sufficient #4999

How to test

DevOps Checklist

[codecov]

Codecov Report

Merging #5008 (de79b63) into master (d1f2dc6) will decrease coverage by 22.0%.
The diff coverage is 95.6%.

@@            Coverage Diff            @@
##           master   #5008      +/-   ##
=========================================
- Coverage    87.2%   65.3%   -22.0%     
=========================================
  Files        1243     547     -696     
  Lines       51157   27808   -23349     
  Branches     1084     198     -886     
=========================================
- Hits        44645   18177   -26468     
- Misses       6273    9581    +3308     
+ Partials      239      50     -189     

Flag	Coverage Δ
integrationtests	63.6% <ø> (-1.5%)	⬇️
unittests	98.7% <95.6%> (+13.7%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...oscaling/src/simcore_service_autoscaling/models.py	100.0% <100.0%> (ø)
...e_service_autoscaling/modules/auto_scaling_core.py	95.7% <100.0%> (+<0.1%)	⬆️
...scaling/modules/auto_scaling_mode_computational.py	100.0% <ø> (ø)
...ing/src/simcore_service_autoscaling/modules/ec2.py	100.0% <100.0%> (ø)
...service_autoscaling/utils/computational_scaling.py	100.0% <100.0%> (ø)
...ore_service_autoscaling/utils/auto_scaling_core.py	94.2% <0.0%> (ø)

... and 1029 files with indirect coverage changes

[bisgaard-itis]

So, for my understanding: Are these changes related to the issues you mentioned to me were detected by the e2e tests I set up?

[sanderegg]

So, for my understanding: Are these changes related to the issues you mentioned to me were detected by the e2e tests I set up?

@bisgaard-itis : no this is another issue. the one of the e2e I am currently working on it

[pcrespov]

thxthx! ;-)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit de79b63 and detected 0 issues on this pull request.

View more on Code Climate.