Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Maintenance: Enhanced logs on sms service errors and tests image labels #4456

Merged
merged 5 commits into from
Jul 4, 2023
Merged

♻️ Maintenance: Enhanced logs on sms service errors and tests image labels #4456

merged 5 commits into from
Jul 4, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Jul 4, 2023

What do these changes do?

Various improvements:

  • ♻️ Adds user_id (in extras) and masked phone number for sms failures @odeimaiz @sanderegg
    • addresses the issue with failing sms in US
  • ♻️ Adds more validation checks for image-labels in registry, e.g. version in metadata vs image tag @mguidon
    • addresses issue with wrong version of s4l
  • 🔨 Minor improvement in release form

Related issue/s

  • maintenance

How to test

  • test_2fa_sms_failure_during_login
cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_*_login.py

DevOps

None

@pcrespov pcrespov self-assigned this Jul 4, 2023
@pcrespov pcrespov requested a review from odeimaiz July 4, 2023 11:55
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Jul 4, 2023
@pcrespov pcrespov requested a review from mguidon July 4, 2023 11:55
@pcrespov pcrespov added this to the Watermelon milestone Jul 4, 2023
@pcrespov pcrespov force-pushed the maintenance/validation-and-twilio branch from 413d5b2 to dd0179e Compare July 4, 2023 11:56
@pcrespov pcrespov enabled auto-merge (squash) July 4, 2023 11:56
@pcrespov pcrespov disabled auto-merge July 4, 2023 11:56
@pcrespov pcrespov changed the title ♻️ Maintenance: Enhanced logs on sms service errors and tests metadata version. ♻️ Maintenance: Enhanced logs on sms service errors and tests image labels Jul 4, 2023
mguidon
mguidon approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@mguidon mguidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test!

packages/models-library/tests/test_utils_service_io.py Show resolved Hide resolved
packages/models-library/tests/test_utils_service_io.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jul 4, 2023 •
edited
Loading

Codecov Report

Merging #4456 (a04030d) into master (86567d7) will decrease coverage by 2.3%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4456     +/-   ##
========================================
- Coverage    85.4%   83.2%   -2.3%     
========================================
  Files         956     838    -118     
  Lines       42075   38391   -3684     
  Branches      901     464    -437     
========================================
- Hits        35964   31960   -4004     
- Misses       5903    6320    +417     
+ Partials      208     111     -97
Flag Coverage Δ
integrationtests 66.3% <38.4%> (+3.5%) ⬆️
unittests 82.4% <100.0%> (-1.4%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...server/src/simcore_service_webserver/login/_2fa.py 84.6% <100.0%> (+0.2%) ⬆️
.../src/simcore_service_webserver/login/_constants.py 100.0% <100.0%> (ø)
...c/simcore_service_webserver/login/handlers_auth.py 98.0% <100.0%> (+3.7%) ⬆️

... and 220 files with indirect coverage changes

@codeclimate
Copy link

codeclimate bot commented Jul 4, 2023

Code Climate has analyzed commit a04030d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

GitHK
GitHK approved these changes Jul 4, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

services/web/server/src/simcore_service_webserver/login/_constants.py Show resolved Hide resolved
@pcrespov pcrespov enabled auto-merge (squash) July 4, 2023 12:10
@pcrespov pcrespov merged commit cf1c90c into ITISFoundation:master Jul 4, 2023
matusdrobuliak66
matusdrobuliak66 reviewed Jul 4, 2023
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcrespov pcrespov deleted the maintenance/validation-and-twilio branch July 4, 2023 13:34
This was referenced Jul 11, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 left review comments

@sanderegg sanderegg sanderegg approved these changes

@mguidon mguidon mguidon approved these changes

@GitHK GitHK GitHK approved these changes

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

Assignees

@pcrespov pcrespov

Labels
t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Watermelon
Development

Successfully merging this pull request may close these issues.
5 participants
@pcrespov @GitHK @mguidon @sanderegg @matusdrobuliak66