-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Adds custom project's metadata in the webserver API #4421
✨ Adds custom project's metadata in the webserver API #4421
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4421 +/- ##
========================================
- Coverage 82.8% 82.5% -0.4%
========================================
Files 944 898 -46
Lines 40385 39595 -790
Branches 972 584 -388
========================================
- Hits 33452 32671 -781
- Misses 6723 6787 +64
+ Partials 210 137 -73
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good 👍
packages/postgres-database/src/simcore_postgres_database/models/projects_to_jobs.py
Outdated
Show resolved
Hide resolved
35a49a4
to
46f0d19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ask for a review again when this is done.
e2d55a0
to
623c1b0
Compare
services/web/server/src/simcore_service_webserver/projects/_metadata_db.py
Outdated
Show resolved
Hide resolved
ec2d472
to
e61ece9
Compare
This reverts commit 94944ef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice, please consider my comments
...src/simcore_postgres_database/migration/versions/f3285aff5e84_new_projects_metadata_table.py
Outdated
Show resolved
Hide resolved
packages/postgres-database/src/simcore_postgres_database/utils_projects_metadata.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_access_rights_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_access_rights_db.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/_metadata_api.py
Outdated
Show resolved
Hide resolved
services/web/server/src/simcore_service_webserver/projects/exceptions.py
Outdated
Show resolved
Hide resolved
3ae0229
to
c489d20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Code Climate has analyzed commit 9d263d8 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Implements
get/update_project_metadata
operations onweb-server
side for this exchange with thepublic-api
to manage custom metadata (i.e. user-defined) on a projectThe connection with the api-server will be done in a separate PR for clarity.
The project metadata is then stored in the database in a new table
projects_metadata
. This table should keep "third-party" metadata attached to a project. This info SHOULD NOT be actual properties of the project (e.g. uuid, name etc) but rather extra information attached by third-parties that "decorate" or qualify a project resource. e.g. things like 'stars', 'quality', 'classifiers', 'dev', etc (or any kind of stats) should be moved here. This is an ERD with some of the tables associated to theprojects
tableHighlights
projects/{project_id}/metadata/custom
project's sub-resourcewebserver
API (v0.24.0
)projects
_handlers
,_api
,_db
api
for "project's access rights"projects_metadata
to include (for now) user custom metadata.Related issue/s
How to test
packages/postgres-database/tests/test_utils_projects_metadata.py
services/web/server/tests/unit/with_dbs/02/test_projects_metadata_handlers.py
DevOps
projects_metadata
tableNOTE: copy & paste diagrams in https://mermaid.live/