Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend: Student competition announcement #4404

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Jun 22, 2023

What do these changes do?

SC2023

Related issue/s

How to test

DevOps Checklist

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:✨new-feature labels Jun 22, 2023
@odeimaiz odeimaiz added this to the Watermelon milestone Jun 22, 2023
@odeimaiz odeimaiz self-assigned this Jun 22, 2023
@odeimaiz odeimaiz changed the title ✨ Student competition announcement ✨ Frontend: Student competition announcement Jun 22, 2023
@pcrespov
Copy link
Member

pcrespov commented Jun 22, 2023

Some ideas for the future regarding pop-ups announcements to users.

@odeimaiz
Copy link
Member Author

Some ideas for the future regarding pop-ups announcements to users.

The frontend part has been implemented based on the Maintenance logic, only the API and the backend part would be needed.

@pcrespov
Copy link
Member

@odeimaiz what about adding it as well in the "bell" or in the "yellow banner" ?? Perhaps we can reuse the redis-maintenance mechanism for any kind of announcement? e.g. front-end detects it is a normal announcement or maintenance?

@odeimaiz
Copy link
Member Author

odeimaiz commented Jun 22, 2023

@odeimaiz what about adding it as well in the "bell" or in the "yellow banner" ?? Perhaps we can reuse the redis-maintenance mechanism for any kind of announcement? e.g. front-end detects it is a normal announcement or maintenance?

The yellow banner is, at the moment, only used to show warning messages. The bell would be a valid option, but we prefer the user menu one, moreover it would require backend work.

@codeclimate
Copy link

codeclimate bot commented Jun 22, 2023

Code Climate has analyzed commit 364b001 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit d851641 into ITISFoundation:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants