♻️ Refactors projects plugin sub-modules as controller-service-repository

[pcrespov]

What do these changes do?

Reorganizing webserver's projects plugin to reflect controller-service-repository pattern.

For instance, let's assume a project's sub-resource foo. It should be split in three submodules as

• projects/_foo_handlers.py : controler
• projects/_foo_api.py: service
• projects/_foo_db.py: repository

This PR adapts only some of the submodules, namely:

• projects/ports
• projects/permalinks
• projects/nodes
• projects/tags
• deprecated nodes submodule was removed. i.e. they are not used.

Related issue/s

• follows up pattern above as proposed by @matusdrobuliak66
• follows up on projects extensions of ✨ 🗃️ adding projects_comments DB table and API endpoints #4383 and ✨ Node previews for project homepage #4379

How to test

In-place

DevOps

None

[codecov]

Codecov Report

Merging #4389 (269420e) into master (48d29cd) will decrease coverage by 1.6%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #4389      +/-   ##
=========================================
- Coverage    86.1%   84.6%    -1.6%     
=========================================
  Files         987     394     -593     
  Lines       42403   20695   -21708     
  Branches     1006     173     -833     
=========================================
- Hits        36551   17511   -19040     
+ Misses       5621    3135    -2486     
+ Partials      231      49     -182     

Flag	Coverage Δ
integrationtests	67.9% <62.5%> (+<0.1%)	⬆️
unittests	86.6% <100.0%> (+2.8%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...mcore_service_webserver/projects/_permalink_api.py	97.5% <ø> (ø)
...c/simcore_service_webserver/projects/_ports_api.py	93.9% <ø> (ø)
...mcore_service_webserver/projects/_tags_handlers.py	92.8% <ø> (ø)
...e_service_webserver/projects/_crud_create_utils.py	96.8% <100.0%> (ø)
...ore_service_webserver/projects/_crud_read_utils.py	97.5% <100.0%> (ø)
...mcore_service_webserver/projects/_handlers_crud.py	82.0% <100.0%> (ø)
...c/simcore_service_webserver/projects/_nodes_api.py	77.9% <100.0%> (ø)
...core_service_webserver/projects/_nodes_handlers.py	89.1% <100.0%> (ø)
...core_service_webserver/projects/_ports_handlers.py	94.3% <100.0%> (ø)
...imcore_service_webserver/projects/_rest_schemas.py	100.0% <100.0%> (ø)
... and 3 more

... and 669 files with indirect coverage changes

[matusdrobuliak66]

great! thanks 👍

[GitHK]

A few considerations:

• I would personally prefer to use *_repository.py in place of *_db.py since: it can be Postregres, it can be Redis, it can be S3.
• why are the nodes api endpoints deleted? I found nothing in the description of the PR

[pcrespov]

• I would personally prefer to use *_repository.py in place of *_db.py since: it can be Postregres, it can be Redis, it can be S3.

• IMO db is good enough (discussed with @matusdrobuliak66), otherwise the names become far too long. Same way that we do not write service but api.

• why are the nodes api endpoints deleted? I found nothing in the description of the PR

• They were deprecated (it was actually written in the description but now i have highlighted it). We never used them.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit 269420e and detected 0 issues on this pull request.

View more on Code Climate.

[sanderegg]

ok. if possible, wait for my PR about node resources to go in before pushing this one.