Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛Fix node progress value when the service did not run yet #4277

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 26, 2023

What do these changes do?

fixes issue brought in by #4273

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label May 26, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 26, 2023
@sanderegg sanderegg self-assigned this May 26, 2023
@sanderegg sanderegg requested a review from mguidon May 26, 2023 12:03
@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented May 26, 2023

Code Climate has analyzed commit ce3b03f and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #4277 (ce3b03f) into master (d8698f4) will decrease coverage by 1.4%.
The diff coverage is 0.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4277      +/-   ##
=========================================
- Coverage    85.7%   84.4%    -1.4%     
=========================================
  Files         971     255     -716     
  Lines       41852   12880   -28972     
  Branches      964       0     -964     
=========================================
- Hits        35900   10879   -25021     
+ Misses       5731    2001    -3730     
+ Partials      221       0     -221     
Flag Coverage Δ
integrationtests ?
unittests 84.4% <0.0%> (+1.8%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/projects/projects_api.py 83.3% <0.0%> (-10.1%) ⬇️

... and 750 files with indirect coverage changes

@sanderegg sanderegg merged commit 424c6e4 into ITISFoundation:master May 26, 2023
@sanderegg sanderegg deleted the bugfix/handling-progress-none branch May 26, 2023 12:19
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 14, 2023
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant