Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Comp backend: disconnect progress update in webserver #4273

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented May 25, 2023

What do these changes do?

  • webserver does not anymore update the progress in the projects table
  • webserver only transfer the progress update to the connected client if needed

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added a:webserver issue related to the webserver service a:director-v2 issue related with the director-v2 service labels May 25, 2023
@sanderegg sanderegg added this to the Pastel de Nata milestone May 25, 2023
@sanderegg sanderegg self-assigned this May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #4273 (7a35e2d) into master (0e8309f) will decrease coverage by 1.9%.
The diff coverage is 93.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4273      +/-   ##
=========================================
- Coverage    88.2%   86.4%    -1.9%     
=========================================
  Files         560     898     +338     
  Lines       27586   40369   +12783     
  Branches      550     832     +282     
=========================================
+ Hits        24349   34893   +10544     
- Misses       3105    5283    +2178     
- Partials      132     193      +61     
Flag Coverage Δ
integrationtests 68.9% <91.8%> (+<0.1%) ⬆️
unittests 83.2% <55.1%> (-1.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...odels-library/src/models_library/projects_nodes.py 91.8% <ø> (ø)
...ls-library/src/models_library/rabbitmq_messages.py 88.6% <60.0%> (ø)
...ice_webserver/notifications/_rabbitmq_consumers.py 98.5% <96.0%> (+2.8%) ⬆️
...ackages/service-library/src/servicelib/rabbitmq.py 94.4% <100.0%> (+0.1%) ⬆️
...re_service_webserver/notifications/project_logs.py 100.0% <100.0%> (ø)
...simcore_service_webserver/projects/projects_api.py 93.4% <100.0%> (-0.2%) ⬇️
...src/simcore_service_webserver/socketio/messages.py 94.2% <100.0%> (-0.8%) ⬇️

... and 345 files with indirect coverage changes

@sanderegg sanderegg requested a review from mguidon May 25, 2023 16:34
@sanderegg sanderegg force-pushed the comp-backend/disconnect-progress-update branch from 3329607 to 152fa9d Compare May 26, 2023 07:52
@codeclimate
Copy link

codeclimate bot commented May 26, 2023

Code Climate has analyzed commit 7a35e2d and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg merged commit d8698f4 into ITISFoundation:master May 26, 2023
@sanderegg sanderegg deleted the comp-backend/disconnect-progress-update branch May 26, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:director-v2 issue related with the director-v2 service a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants