♻️Flaky: wait for migration service to be finished upgrading

[sanderegg]

What do these changes do?

• reverted changes in postgres_utils.py (waiting for migration service)
• wait for task to be started in docker_stack fixture
• migration service healthcheck already tells us if the migration was properly done or not.
• added a manual integration test in the migration service to test the migration

Related issue/s

• relates with M1-12 Maintenance and DevOps osparc-issues#675

How to test

DevOps Checklist

[codecov]

Codecov Report

Merging #4203 (666d9e0) into master (2e8d8e4) will increase coverage by 0.8%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #4203     +/-   ##
========================================
+ Coverage    83.9%   84.8%   +0.8%     
========================================
  Files         961     961             
  Lines       41640   41640             
  Branches      955     955             
========================================
+ Hits        34951   35317    +366     
+ Misses       6472    6106    -366     
  Partials      217     217             

Flag	Coverage Δ
integrationtests	62.3% <ø> (-0.1%)	⬇️
unittests	82.3% <ø> (+0.9%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

[mrnicegyu11]

Supernice, thx.

Question for my learning:

• What is a gitkeep file?
• What is this ... syntax in the last test? You dont execute any python commands?

[sanderegg]

Supernice, thx.

Question for my learning:

• What is a gitkeep file?
• What is this ... syntax in the last test? You dont execute any python commands?

@mrnicegyu11

• the .gitkeep file is to ensure that git keeps the folder in git. otherwise empty folders are not pulled, which makes the make test* recipes fail
• ... is indeed doing nothing, it just executes the fixtures.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[codeclimate]

Code Climate has analyzed commit 666d9e0 and detected 0 issues on this pull request.

View more on Code Climate.