Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Maintenance: adds session-scoped fixture for httpbin service #4194

Merged
merged 11 commits into from
May 6, 2023

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented May 4, 2023

What do these changes do?

  • adds httpbin_base_url in pytest_plugins=[ ..., "pytest_simcore.httpbin_service", ... ]

Related issue/s

@pcrespov pcrespov self-assigned this May 4, 2023
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label May 4, 2023
@pcrespov pcrespov added this to the Pastel de Nata milestone May 4, 2023
@pcrespov pcrespov force-pushed the maintenance/httpbin-fixture branch from b01909e to 024927b Compare May 4, 2023 13:06
@pcrespov pcrespov marked this pull request as ready for review May 4, 2023 13:09
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #4194 (08c97e1) into master (dafc3a9) will increase coverage by 1.3%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #4194     +/-   ##
========================================
+ Coverage    83.7%   85.1%   +1.3%     
========================================
  Files         810     849     +39     
  Lines       36870   38438   +1568     
  Branches      585     955    +370     
========================================
+ Hits        30894   32738   +1844     
+ Misses       5853    5483    -370     
- Partials      123     217     +94     
Flag Coverage Δ
integrationtests 67.2% <ø> (+21.3%) ⬆️
unittests 81.6% <ø> (-1.2%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 205 files with indirect coverage changes

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@pcrespov pcrespov enabled auto-merge (squash) May 5, 2023 17:51
@codeclimate
Copy link

codeclimate bot commented May 5, 2023

Code Climate has analyzed commit 08c97e1 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit fe4dee6 into ITISFoundation:master May 6, 2023
@pcrespov pcrespov deleted the maintenance/httpbin-fixture branch May 10, 2023 11:21
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants