Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️Webserver: refactor computations plugin (⚠️ devops) #4162

Merged
merged 12 commits into from
Apr 25, 2023
Merged

♻️Webserver: refactor computations plugin (⚠️ devops) #4162

merged 12 commits into from
Apr 25, 2023

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Apr 25, 2023 •
edited
Loading

What do these changes do?

  • renamed computations to notifications
  • moved to its own subfolder plugin
  • prequel to using topic queues in rabbitmq
  • ⚠️ devops: the ENV WEBSERVER_COMPUTATION is replaced by WEBSERVER_NOTIFICATIONS but is backward compatible so nothing bad will happen.

Related issue/s

How to test

DevOps Checklist

@sanderegg sanderegg added the a:webserver issue related to the webserver service label Apr 25, 2023
@sanderegg sanderegg added this to the Jelly Beans milestone Apr 25, 2023
@sanderegg sanderegg self-assigned this Apr 25, 2023
@sanderegg sanderegg mentioned this pull request Apr 25, 2023
Closed
@sanderegg sanderegg marked this pull request as ready for review April 25, 2023 09:39
@sanderegg sanderegg changed the title ♻️Webserver: refactor computations plugin ♻️Webserver: refactor computations plugin (⚠️ devops) Apr 25, 2023
GitHK
GitHK approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Apr 25, 2023 •
edited
Loading

Codecov Report

Merging #4162 (1ade3ac) into master (5881834) will increase coverage by 20.6%.
The diff coverage is 90.2%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #4162      +/-   ##
=========================================
+ Coverage    57.2%   77.9%   +20.6%     
=========================================
  Files         666     399     -267     
  Lines       29249   20614    -8635     
  Branches      585     173     -412     
=========================================
- Hits        16749   16069     -680     
+ Misses      12377    4496    -7881     
+ Partials      123      49      -74
Flag Coverage Δ
integrationtests 62.2% <87.3%> (+16.8%) ⬆️
unittests 83.9% <79.8%> (+4.6%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_webserver/notifications/_utils.py 100.0% <ø> (ø)
...ver/notifications/_db_comp_tasks_listening_task.py 87.0% <87.0%> (ø)
...erver/src/simcore_service_webserver/application.py 97.8% <100.0%> (+97.8%) ⬆️
.../simcore_service_webserver/application_settings.py 98.7% <100.0%> (+18.4%) ⬆️
...re_service_webserver/application_settings_utils.py 97.7% <100.0%> (+1.1%) ⬆️
...ice_webserver/notifications/_rabbitmq_consumers.py 98.4% <100.0%> (ø)
.../simcore_service_webserver/notifications/plugin.py 100.0% <100.0%> (ø)

... and 471 files with indirect coverage changes

@sanderegg sanderegg force-pushed the maintenance/refactor_webserver_computation branch from f9badd7 to daed72c Compare April 25, 2023 09:54
pcrespov
pcrespov approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

services/web/server/tests/unit/with_dbs/01/notifications/test_utils.py Outdated Show resolved Hide resolved
...ices/web/server/src/simcore_service_webserver/notifications/_db_comp_tasks_listening_task.py Show resolved Hide resolved
...ices/web/server/src/simcore_service_webserver/notifications/_db_comp_tasks_listening_task.py Outdated Show resolved Hide resolved
services/web/server/src/simcore_service_webserver/notifications/_rabbitmq_consumers.py Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Apr 25, 2023

Code Climate has analyzed commit 1ade3ac and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

matusdrobuliak66
matusdrobuliak66 approved these changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg merged commit 0635169 into ITISFoundation:master Apr 25, 2023
@sanderegg sanderegg deleted the maintenance/refactor_webserver_computation branch April 25, 2023 14:03
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Apr 27, 2023
Closed
15 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 30, 2023
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@Surfict Surfict Awaiting requested review from Surfict

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

Assignees

@sanderegg sanderegg

Labels
a:webserver issue related to the webserver service
Projects
None yet
Milestone
Jelly Beans
Development

Successfully merging this pull request may close these issues.
4 participants
@sanderegg @GitHK @pcrespov @matusdrobuliak66