Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Personalized resources: Allow override of computational service needed resources #3971

Closed

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 14, 2023

What do these changes do?

  • remove mpi flag as resource (catalog API /resources endpoint will not return MPI anymore)
  • director-v2 does not pass MPI as a task requirements anymore
  • director-v2 uses catalog to get the computational service resources instead of director-v0, thus allowing for resource override through table services_specifications
  • dask-sidecar boot mode, remove MPI and MPI advertisement
  • pass boot-mode from catalog to director-v2
  • pass boot-mode from director-v2 to dask-sidecar

Related issue/s

How to test

Checklist

@sanderegg sanderegg added a:catalog catalog service a:director-v2 issue related with the director-v2 service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels Mar 14, 2023
@sanderegg sanderegg added this to the Mithril milestone Mar 14, 2023
@sanderegg sanderegg self-assigned this Mar 14, 2023
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #3971 (d6c6038) into master (4aa9a3d) will decrease coverage by 11.8%.
The diff coverage is 9.6%.

❗ Current head d6c6038 differs from pull request most recent head 188246b. Consider uploading reports for the commit 188246b to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3971      +/-   ##
=========================================
- Coverage    85.2%   73.4%   -11.8%     
=========================================
  Files         943     442     -501     
  Lines       40680   20609   -20071     
  Branches      848      93     -755     
=========================================
- Hits        34665   15131   -19534     
+ Misses       5792    5459     -333     
+ Partials      223      19     -204     
Flag Coverage Δ
integrationtests ?
unittests 73.4% <9.6%> (-8.7%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...service_webserver/director_v2_core_computations.py 64.4% <ø> (-30.9%) ⬇️
...vice_webserver/exporter/formatters/formatter_v1.py 27.6% <0.0%> (-55.9%) ⬇️
...rvice_webserver/projects/projects_handlers_crud.py 64.4% <ø> (-28.8%) ⬇️
..._service_webserver/studies_dispatcher/_projects.py 34.0% <0.0%> (-56.0%) ⬇️
...-sidecar/src/simcore_service_dask_sidecar/utils.py 58.6% <7.6%> (-41.4%) ⬇️
...simcore_service_webserver/projects/projects_api.py 62.8% <33.3%> (-31.1%) ⬇️

... and 612 files with indirect coverage changes

@sanderegg sanderegg changed the title ✨ Personalized resources: Allow override of service needed resources ✨ Personalized resources: Allow override of computational service needed resources Mar 14, 2023
@sanderegg sanderegg force-pushed the comp_backend/remove_mpi_flag branch 2 times, most recently from adf4de5 to d6c6038 Compare March 16, 2023 16:37
@sanderegg sanderegg force-pushed the comp_backend/remove_mpi_flag branch from d6c6038 to 188246b Compare March 17, 2023 13:35
@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.9% 6.9% Duplication

@codeclimate
Copy link

codeclimate bot commented Mar 17, 2023

Code Climate has analyzed commit 188246b and detected 0 issues on this pull request.

View more on Code Climate.

@sanderegg
Copy link
Member Author

replaced by #3989

@sanderegg sanderegg closed this Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:director-v2 issue related with the director-v2 service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant