Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Idle timer: close study after 30' #3544

Merged
merged 45 commits into from
Jan 24, 2023

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 11, 2022

What do these changes do?

This feature is only enabled for the s4llite product

In order to free resources, when a user has a study open and there is no activity in the osparc tab (mousemove, mousedown and keydown), the frontend will close the study.

After 15', a warning message with a countdown will pop up saying: Are you still there? If not, the project will be closed in XX:XX. When the countdown goes down to 0, the study will get closed.

Demo with timeout set to 20" and warning to 10":
IdleTimeout

Related issue/s

Idle timeout: ITISFoundation/osparc-issues#765

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Nov 11, 2022
@odeimaiz odeimaiz added this to the Athena milestone Nov 11, 2022
@odeimaiz odeimaiz self-assigned this Nov 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz changed the title ✨ WIP: Idle timer ✨ Idle timer: close study after 30' Jan 23, 2023
@odeimaiz odeimaiz marked this pull request as ready for review January 23, 2023 12:41
@odeimaiz odeimaiz enabled auto-merge (squash) January 23, 2023 13:02
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nice

Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice!

Suggestion: someone might understand that there's an absolute max time they're allowed to use the project, so I would clarify that it's only if idle.

The message can become something like "The project will be closed in ... due to inactivity. If you're still using it you can ignore this message."

@odeimaiz
Copy link
Member Author

The message can become something like "The project will be closed in ... due to inactivity. If you're still using it you can ignore this message."

If you are using it, you won't get the message.

  • The timer is started when the inactivity starts
  • 15' later you will get the message
  • 30' after the inactivity timer started and if you are still inactive, the study gets closed

@elisabettai
Copy link
Collaborator

elisabettai commented Jan 23, 2023

The message can become something like "The project will be closed in ... due to inactivity. If you're still using it you can ignore this message."

If you are using it, you won't get the message.

* The timer is started when the inactivity starts

* 15' later you will get the message

* 30' after the inactivity timer started and if you are still inactive, the study gets closed

That's clear.

If the user comes back after 20' from the start of the inactivity, I suppose he will see the message.
At that point he might resume working on the project again and the timer is reset, I suppose. In this case I was thinking it might be worth notifying him that he can resume working without being worried that the project will be closed after 10'.

@codeclimate
Copy link

codeclimate bot commented Jan 24, 2023

Code Climate has analyzed commit 5ab64f6 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 6cd2e99 into ITISFoundation:master Jan 24, 2023
@odeimaiz odeimaiz deleted the feature/idle-timer branch August 20, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants