-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Frontend: S4L Light product #3503
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3503 +/- ##
=========================================
+ Coverage 83.4% 83.7% +0.2%
=========================================
Files 834 349 -485
Lines 35446 17823 -17623
Branches 748 133 -615
=========================================
- Hits 29583 14919 -14664
+ Misses 5673 2855 -2818
+ Partials 190 49 -141
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! :-)
I still think all graphic assets should be moved outside from the repository. This way designers/artists can change those at any time without having to go through all the PR+CI+deploys ... which is currently is in the order of "days" if you want e.g. to deploy in production.
Correct. But still, if the designers create a logo which is a bit wider, than the placeholder, we might need to update few numbers in the code, or if we simply want to update one text we also need to go through all the deployments mechanism... I agree that moving all these images outside would provide more flexibility, but the branding is not just logos. |
Just a thought: I am no expert but isn't there any technique in which you can parametrize those "style values" as well? CSS?? then we could do the same with those and the images. |
This external provider could also host a css or a json file with metadata, but the frontend layouts might need to be resized or rearranged. |
S4L Light (s4llight):
What do these changes do?
Related issue/s
related to ITISFoundation/osparc-issues#740
How to test
Checklist