Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend: S4L Light product #3503

Merged
merged 15 commits into from
Nov 3, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Nov 2, 2022

S4L Light (s4llight):

  • Frontend app
  • Logos
  • Dashboard
    • One + button only: sim4life
    • Templates -> Tutorials
    • Hide Data
  • Do not show maximize/restore iframe button

Sim4LifeLight

What do these changes do?

Related issue/s

related to ITISFoundation/osparc-issues#740

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Nov 2, 2022
@odeimaiz odeimaiz changed the title ✨ WIP: Frontend: S4L light product ✨ WIP: Frontend: S4L Light product Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3503 (e4eb958) into master (91774ae) will increase coverage by 0.2%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3503      +/-   ##
=========================================
+ Coverage    83.4%   83.7%    +0.2%     
=========================================
  Files         834     349     -485     
  Lines       35446   17823   -17623     
  Branches      748     133     -615     
=========================================
- Hits        29583   14919   -14664     
+ Misses       5673    2855    -2818     
+ Partials      190      49     -141     
Flag Coverage Δ
integrationtests 67.5% <100.0%> (-0.1%) ⬇️
unittests 82.2% <100.0%> (+1.7%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eb/server/src/simcore_service_webserver/statics.py 62.5% <ø> (ø)
...er/src/simcore_service_webserver/statics_events.py 39.2% <ø> (ø)
...src/simcore_service_webserver/statics_constants.py 100.0% <100.0%> (ø)
...-v2/src/simcore_service_director_v2/cli/_client.py 0.0% <0.0%> (-100.0%) ⬇️
...v2/src/simcore_service_director_v2/cli/__init__.py 0.0% <0.0%> (-100.0%) ⬇️
...service_director_v2/cli/_close_and_save_service.py 0.0% <0.0%> (-100.0%) ⬇️
...or-v2/src/simcore_service_director_v2/cli/_core.py 0.0% <0.0%> (-87.5%) ⬇️
...ce_director_v2/modules/db/repositories/clusters.py 23.0% <0.0%> (-71.7%) ⬇️
...ervice_director_v2/api/routes/dynamic_scheduler.py 38.2% <0.0%> (-57.4%) ⬇️
...k/src/simcore_sdk/node_ports_v2/port_validation.py 47.9% <0.0%> (-48.0%) ⬇️
... and 549 more

@odeimaiz odeimaiz marked this pull request as ready for review November 2, 2022 16:02
@odeimaiz odeimaiz changed the title ✨ WIP: Frontend: S4L Light product ✨ Frontend: S4L Light product Nov 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! :-)

I still think all graphic assets should be moved outside from the repository. This way designers/artists can change those at any time without having to go through all the PR+CI+deploys ... which is currently is in the order of "days" if you want e.g. to deploy in production.

@odeimaiz
Copy link
Member Author

odeimaiz commented Nov 2, 2022

looks good! :-)

I still think all graphic assets should be moved outside from the repository. This way designers/artists can change those at any time without having to go through all the PR+CI+deploys ... which is currently is in the order of "days" if you want e.g. to deploy in production.

Correct. But still, if the designers create a logo which is a bit wider, than the placeholder, we might need to update few numbers in the code, or if we simply want to update one text we also need to go through all the deployments mechanism...

I agree that moving all these images outside would provide more flexibility, but the branding is not just logos.

@pcrespov
Copy link
Member

pcrespov commented Nov 2, 2022

Correct. But still, if the designers create a logo which is a bit wider, than the placeholder, we might need to update few numbers in the code, or if we simply want to update one text we also need to go through all the deployments mechanism...

Just a thought: I am no expert but isn't there any technique in which you can parametrize those "style values" as well? CSS?? then we could do the same with those and the images.

@odeimaiz
Copy link
Member Author

odeimaiz commented Nov 2, 2022

Correct. But still, if the designers create a logo which is a bit wider, than the placeholder, we might need to update few numbers in the code, or if we simply want to update one text we also need to go through all the deployments mechanism...

Just a thought: I am no expert but isn't there any technique in which you can parametrize those "style values" as well? CSS?? then we could do the same with those and the images.

This external provider could also host a css or a json file with metadata, but the frontend layouts might need to be resized or rearranged.

@odeimaiz odeimaiz merged commit 31d979b into ITISFoundation:master Nov 3, 2022
@odeimaiz odeimaiz deleted the feature/s4l-light-I branch November 3, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants