-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oSPARC-S4L M2 ready #2555
oSPARC-S4L M2 ready #2555
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2555 +/- ##
======================================
Coverage 76.8% 76.8%
======================================
Files 623 623
Lines 24048 24050 +2
Branches 2356 2357 +1
======================================
+ Hits 18488 18494 +6
+ Misses 4932 4929 -3
+ Partials 628 627 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks all good to me - should it also have StS's review?
Just two comments:
- I'm not sure it makes sense to allow making a node invisible through the "quick edit" since none of the other operations are possible (e.g. making a node visible, rearranging nodes) so it might be confusing to only that one function available. However if the PO's wanted it like that, then ignore my comment =)
- When a new node is created via the guided mode "quick edit" and ports cannot be auto-connected perhaps there should be a warning?
When you start the App Mode all nodes are added to the breadcrumbs, the App/GM mode designer might want to keep a computational service hidden (it will be run when the user "steps over") |
review in progress... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo indicator icons in dashboard items should have some sort of explanatory tooltip
What do these changes do?
Milestone 2 ready:
App mode
concept implemented:App mode
can be started and, by default, the entire pipeline will be part of the slideshowGuided mode
/App mode
, the instance will be started in that modeGuided mode
vsApp mode
:Persistent and icons:
App mode
template:Add nodes from breadcrumbs:
Related issue/s
related to ITISFoundation/osparc-issues#496
closes #2561
Disable share link for templates #2560
How to test
Checklist