From 87637bb9277eb56f53b519979ce8b9f69d2df0ca Mon Sep 17 00:00:00 2001 From: Pedro Crespo-Valero <32402063+pcrespov@users.noreply.github.com> Date: Tue, 16 Apr 2024 11:49:15 +0200 Subject: [PATCH] reverts changes in #5659 --- .../src/simcore_service_storage/handlers_files.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/services/storage/src/simcore_service_storage/handlers_files.py b/services/storage/src/simcore_service_storage/handlers_files.py index 3ec5699744c..3bb4dae2451 100644 --- a/services/storage/src/simcore_service_storage/handlers_files.py +++ b/services/storage/src/simcore_service_storage/handlers_files.py @@ -93,15 +93,18 @@ async def get_file_metadata(request: web.Request) -> web.Response: file_id=path_params.file_id, ) except FileMetaDataNotFoundError: - # NOTE: This is what happens Larry... data must be an empty {} or else some old - # dynamic services will FAIL (sic) - # TODO: once all legacy services are gone, remove the try except, it will default to 404 + # NOTE: LEGACY compatibility + # This is what happens Larry... data must be an empty {} or else some old dynamic services will FAIL (sic) + # Cannot remove until we retire all legacy services + # https://github.com/ITISFoundation/osparc-simcore/issues/5676 + # https://github.com/ITISFoundation/osparc-simcore/blob/cfdf4f86d844ebb362f4f39e9c6571d561b72897/services/storage/client-sdk/python/simcore_service_storage_sdk/models/file_meta_data_enveloped.py#L34 + return web.json_response( - {"error": "No result found", "data": None}, dumps=json_dumps + {"error": "No result found", "data": {}}, dumps=json_dumps ) if request.headers.get("User-Agent") == "OpenAPI-Generator/0.1.0/python": - # LEGACY compatiblity with API v0.1.0 + # NOTE: LEGACY compatiblity with API v0.1.0 # SEE models used in sdk in: # https://github.com/ITISFoundation/osparc-simcore/blob/cfdf4f86d844ebb362f4f39e9c6571d561b72897/services/storage/client-sdk/python/simcore_service_storage_sdk/models/file_meta_data_enveloped.py#L34 # https://github.com/ITISFoundation/osparc-simcore/blob/cfdf4f86d844ebb362f4f39e9c6571d561b72897/services/storage/client-sdk/python/simcore_service_storage_sdk/models/file_meta_data_type.py#L34