Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opencor #84

Merged
merged 12 commits into from
Jan 20, 2021
Merged

Update opencor #84

merged 12 commits into from
Jan 20, 2021

Conversation

KZzizzle
Copy link
Collaborator

@KZzizzle KZzizzle commented Jan 18, 2021

What do these changes do?

Updates the base image used for the OpenCOR service, provided by MAP-Core. In addition, updated the github CI yml because setting the environment is now different. Also updated the CI (and bumped versions) for:

  • cardiac_myocyte_grandi
  • pmr_mrg
  • opencorservice_demo

Related issue number

ITISFoundation/osparc-issues#26

Checklist

  • I think the code is well written
  • I updated the table of contents (make toc)
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@KZzizzle
Copy link
Collaborator Author

Also updated all the opencore-related services and also the Eleonora Grandi one

@sanderegg sanderegg added this to the Chronos milestone Jan 19, 2021
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful! let's get that in

@KZzizzle KZzizzle merged commit 7d3ce40 into ITISFoundation:master Jan 20, 2021
@KZzizzle KZzizzle deleted the update_opencor branch January 20, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants