Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M6 Support for unit conversion and detection of compatible ports #515

Open
odeimaiz opened this issue Sep 14, 2021 · 2 comments
Open

M6 Support for unit conversion and detection of compatible ports #515

odeimaiz opened this issue Sep 14, 2021 · 2 comments
Assignees
Labels
Epic Zenhub label (Pleas do not modify) PO issue Created by Product owners

Comments

@odeimaiz
Copy link
Member

Ports of services can already be annotated with units and this information can be used to identify compatibility when pipelining services. This functionality must be extended to deal with equivalent units (e.g., mA/s and C/min^2) in order to ensure correct data conversion when passing it from service to service, as well as port compatibility assessment.

Deliverable: platform functionality (Q2)

@odeimaiz odeimaiz added the PO issue Created by Product owners label Sep 14, 2021
@odeimaiz odeimaiz changed the title Support for unit conversion and detection of compatible ports M6 Support for unit conversion and detection of compatible ports Sep 14, 2021
@odeimaiz
Copy link
Member Author

"It would be nice if we could implement the range validation for input values" says @KZzizzle

@pcrespov
Copy link
Member

pcrespov commented Feb 24, 2022

"It would be nice if we could implement the range validation for input values" says @KZzizzle

@KZzizzle @odeimaiz PR ITISFoundation/osparc-simcore#2756 includes jsonschemas in ports which allows, among other constraints, range validation. For now, the validation takes places when node-ports is executed (i.e. prior to the actual service run) . In some cases this could be validated earlier even without running the pipeline. The latter is still not included.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Zenhub label (Pleas do not modify) PO issue Created by Product owners
Projects
None yet
Development

No branches or pull requests

3 participants