IQSS/10117-increase-guestbook-question-length

[qqmyers]

What this PR does / why we need it: This PR increases the allowed length of a custom question (was 255 chars, now up to limit of the postgres text type) and fixes the code that was hiding any error when a guestbook create/edit failed (due to this or other reason causing a CommandException).

Which issue(s) this PR closes:

• Closes Guestbook custom questions limited to 255 chars and creating one fails silently if you go over that limit #10117
• Closes Creating a guestbook with a custom question that has more than 255 characters says "success" but silently fails #9492

Special notes for your reviewer: Accidentally committed to develop, reverted everything, and added a new commit here to restore everything.

Suggestions on how to test this: Try creating/editing a guestbook with a custom question over 255 chars in length. Before the PR, you'll see a success message and no new guestbook/guestbook update. After the PR, the change will succeed. If you also want to test the error fix, run ALTER TABLE customquestion ALTER COLUMN questionstring TYPE varchar(10); or similar low number and try to add a question longer than that. (setting TYPE back to text as in the flyway script will restore your db).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: fairly minor issue but I added one

Additional documentation:

[coveralls]

coverage: 21.854%. remained the same
when pulling 1d300f4 on QualitativeDataRepository:IQSS/10117-customquestion_limit_and_failure
into befc5a9 on IQSS:develop.

[cmbz]

2023/12/18: Also closes #9492

[stevenwinship]

This file needs to be renamed V6.5....

[pdurbin]

@stevenwinship @qqmyers @ofahimIQSS Jenkins tests are failing. Does anyone know why?

[stevenwinship]

@stevenwinship @qqmyers @ofahimIQSS Jenkins tests are failing. Does anyone know why?

[Pipeline] script
[Pipeline] {
[Pipeline] fileExists
[Pipeline] error
[Pipeline] }
[Pipeline] // script
[Pipeline] }
[Pipeline] // stage
[Pipeline] }
[Pipeline] // withEnv
[Pipeline] }
[Pipeline] // node
[Pipeline] End of Pipeline
ERROR: Ansible run terminated abnormally, failing build.

GitHub has been notified of this commit’s build result

Finished: FAILURE

[stevenwinship]

"System is booting up. Unprivileged users are not permitted to log in yet. Please come back later. For technical details, see pam_nologin(8)."
Connection closed by 3.236.18.81 port 22
lost connection

[ofahimIQSS]

No issues found during testing - Merging PR
Testing of 10118.docx