Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Confirmation pop-up to confirm ['Grant' access/assign access permissions] to Restricted data #5610

Closed
mdmADA opened this issue Mar 7, 2019 · 6 comments
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Permissions Type: Suggestion an idea User Role: Depositor Creates datasets, uploads data, etc.

Comments

@mdmADA
Copy link
Contributor

mdmADA commented Mar 7, 2019

To prevent an inadvertent release of restricted data, when an admin-type user:

  • clicks "Grant" for a restricted file OR
  • assigns access permissions to a user/group on a dataset that contains at least one Restricted file

=> pop up a confirmation: "You are granting access to Restricted files. Continue?" with Continue/Cancel buttons (or something similar) to remind the user to double-check they want to grant access to that user/group for that restricted data.

@pdurbin
Copy link
Member

pdurbin commented Mar 7, 2019

@mdmADA makes sense. Is this a feature you're considering implementing? And making a pull request? Or are you just putting the idea out there? Hopefully, people who are clicking "Grant" understand that the "Grant" button only appears for restricted files. (The user who wants the file has gone through the "request access" workflow already.) Files that are not restricted can simply be downloaded (though sometimes there are some click through Terms of Use to agree to or a guestbook to fill out). I understand that in your installation 99% of files are restricted so your users may not encounter public (non-restricted) files very often.

@mdmADA
Copy link
Contributor Author

mdmADA commented Mar 7, 2019

Hi Phil - Perhaps the 'warning' would have to be a bit more specific - "You are about to Grant access for <dataset/datafile> to (s)" or something to remind the "granter" to double-check who they're about to grant it to.

Our admin-type users know that Grant only appears for requested (restricted) data but not all who request access should be granted access so it would be an additional visual reminder to double check who you're about to grant it to. When you have a lot of people requesting access at once, it might (?) be easy to accidentally include somebody that shouldn't have access.

Perhaps such a pop-up would apply to only to "ultra-sensitive" data if there is going to be such a designation (or similar) in the sensitive data rollout.

Or perhaps the pop-up should be triggered by a flag to set for extremely sensitive data/datasets -> this might be a more effective solution since the user would really take notice when it did pop up - "Hey, this is extremely sensitive - make sure you double check who you're giving this to".

As for implementation, I put it out there as an idea. I am not sure when I would be able to get to it to implement it myself...

Thanks!

@TaniaSchlatter
Copy link
Member

Potentially related to #871 – Integrate with Datatags

@pdurbin
Copy link
Member

pdurbin commented Oct 13, 2022

@mdmADA hi! It's been little while. Still interested in this? Thanks.

@mdmADA
Copy link
Contributor Author

mdmADA commented Oct 14, 2022

Hi @pdurbin - It has been a while. ADA is interested in it as a double check, but it isn't critical.

Thanks!

@cmbz
Copy link

cmbz commented Aug 20, 2024

To focus on the most important features and bugs, we are closing issues created before 2020 (version 5.0) that are not new feature requests with the label 'Type: Feature'.

If you created this issue and you feel the team should revisit this decision, please reopen the issue and leave a comment.

@cmbz cmbz closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: JSF Involves modifying JSF (Jakarta Server Faces) code, which is being replaced with React. Feature: Permissions Type: Suggestion an idea User Role: Depositor Creates datasets, uploads data, etc.
Projects
None yet
Development

No branches or pull requests

4 participants