Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid schema and metadataNamespace fields in OAI-PMH ListMetadataFormats response #3621

Closed
tdilauro opened this issue Feb 2, 2017 · 9 comments · Fixed by #9210
Closed
Assignees
Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards Size: 10 A percentage of a sprint. 7 hours. User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Milestone

Comments

@tdilauro
Copy link
Contributor

tdilauro commented Feb 2, 2017

The metadataFormat chunk for prefix dataverse_json looks like:

<metadataFormat>
   <metadataPrefix>dataverse_json</metadataPrefix>
   <schema>JSON schema pending</schema>
   <metadataNamespace>Custom Dataverse metadata in JSON format (Dataverse4 to Dataverse4 harvesting only)</metadataNamespace>
</metadataFormat>

The value for metadataNamespace should be a URI and the value for schema should be a URL, but any URI will validate. In the short term, it might be reasonable to make up values in the http://dataverse.org namespace, so that the responses comply with the OAI-PMH 2.0 schema.

@pdurbin
Copy link
Member

pdurbin commented Feb 3, 2017

Another place where I thought about using a namespace for Dataverse was in the context of SWORD. I ended up using new QName(UriRegistry.SWORD_STATE... instead to yield <dataverseHasBeenReleased xmlns="http://purl.org/net/sword/terms/state">true</dataverseHasBeenReleased> but at the time I was wondering if we should have a URL under purl or under dataverse.org, like @tdilauro suggests.

@pdurbin pdurbin added the User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh label Jul 4, 2017
@pdurbin
Copy link
Member

pdurbin commented Apr 12, 2022

These days we're using URLs like https://dataverse.org/schema/citation/... in our experimental Semantic Metadata API.

See this pull request for examples:

@mreekie mreekie moved this to NIH (Stefano) in IQSS Dataverse Project Nov 2, 2022
@mreekie mreekie moved this from NIH bklog#000 (Stefano) to 1️⃣ 📃✔▶ORDERED BACKLOG (Stefano) in IQSS Dataverse Project Nov 21, 2022
@mreekie mreekie moved this from 1️⃣ ▶ORDERED BACKLOG (Stefano) to 2️⃣▶ SPRINT PREP in IQSS Dataverse Project Nov 22, 2022
@sekmiller
Copy link
Contributor

@tdilauro we are reviewing old tickets related to Harvesting. I was hoping that you could answer the following questions to help us determine if this issue is still open and if so, how to go about fixing it. Thanks!

What steps does it take to reproduce the issue?


•	When does this issue occur?

•	Which page(s) does it occurs on?

•	What happens?

•	To whom does it occur (all users, curators, superusers)?

•	What did you expect to happen?


Which version of Dataverse are you using?

@sekmiller
Copy link
Contributor

I've reached out to the author of the ticket for more information, but it's possible that this is not applicable to DV 5.x since there's a reference in the original post to "(Dataverse4 to Dataverse4 harvesting only)"

It's difficult to estimate the effort without additional information, as I have not been able to reproduce the error state.

dataverse_json
JSON schema pending
Custom Dataverse metadata in JSON format (Dataverse4 to Dataverse4 harvesting only)

@poikilotherm
Copy link
Contributor

Sorry to chime in, stumbled over this one.

Looking at https://demo.dataverse.org/oai?verb=ListMetadataFormats, it looks like we still are sending out that information.

It should be a very simple fix, looking at

private Context addDataverseJsonMetadataFormat(Context context) {
MetadataFormat metadataFormat = MetadataFormat.metadataFormat(DATAVERSE_EXTENDED_METADATA_FORMAT);
metadataFormat.withNamespace(DATAVERSE_EXTENDED_METADATA_NAMESPACE);
metadataFormat.withSchemaLocation(DATAVERSE_EXTENDED_METADATA_SCHEMA);
context.withMetadataFormat(metadataFormat);
return context;
}
and
private static final String DATAVERSE_EXTENDED_METADATA_NAMESPACE = "Custom Dataverse metadata in JSON format (Dataverse4 to Dataverse4 harvesting only)";
.

@sekmiller
Copy link
Contributor

Thanks, Oliver.

@mreekie mreekie added the Size: 10 A percentage of a sprint. 7 hours. label Nov 30, 2022
@mreekie
Copy link

mreekie commented Nov 30, 2022

sizing: This is part of the OAI servlet. This could be possibly just changing static strings. There are two strings.We should put it in the bundle. This will not be coding. We just need to decide how to change the string to make it more appropriate.
This seems trivial so sized low

@mreekie mreekie moved this from 2️⃣▶ SPRINT PREP (Tech discussion/Sizing) to 3️⃣▶ 💨👟SPRINT READY in IQSS Dataverse Project Nov 30, 2022
@mreekie mreekie moved this from 3️⃣▶ 💨👟SPRINT READY to 🏁In a Sprint or Completed in IQSS Dataverse Project Dec 1, 2022
@sekmiller sekmiller self-assigned this Dec 2, 2022
@mreekie
Copy link

mreekie commented Dec 6, 2022

Daily

  • Originally we thought this would be just adding a URL to the metadata namespace.
  • We don't have the same setup for the JSON schema however.
  • We will need to make a sample, add it to the environment, and add the URL here.
  • This impacts the size of this, possibly significantly.
  • original size: 10

@pdurbin
Copy link
Member

pdurbin commented Dec 6, 2022

From talk after at standup, this this what we agreed on. Note that these are not real URLs!

This is from the OAI_ORE export. At the bottom, the dvcore value is https://dataverse.org/schema/core# . We looked at this example (dvcore is at the bottom): https://dataverse.harvard.edu/api/datasets/export?exporter=OAI_ORE&persistentId=doi%3A10.7910/DVN/TJCLKP

There's a lot more work to do to actually define the JSON Schema for Dataverse:

All we're doing is adding two URLs so that https://demo.dataverse.org/oai?verb=ListMetadataFormats for example validates.

<schema>https://dataverse.org/schema/core.xsd</schema>
<metadataNamespace>
https://dataverse.org/schema/core
</metadataNamespace>

@pdurbin pdurbin added this to the 5.13 milestone Dec 7, 2022
@mreekie mreekie moved this to 🚮Clear of the Backlog in IQSS Dataverse Project Jan 28, 2023
@mreekie mreekie added pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Harvesting NIH OTA: 1.4.1 4 | 1.4.1 | Resolve OAI-PMH harvesting issues | 5 prdOwnThis is an item synched from the product ... pm.GREI-d-1.4.1 NIH, yr1, aim4, task1: Resolve OAI-PMH harvesting issues pm.GREI-d-1.4.2 NIH, yr1, aim4, task2: Create working group on packaging standards Size: 10 A percentage of a sprint. 7 hours. User Role: Sysadmin Installs, upgrades, and configures the system, connects via ssh
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants