Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Dataset: native API actually uses GET not POST #3483

Closed
bmckinney opened this issue Nov 18, 2016 · 3 comments
Closed

Publish Dataset: native API actually uses GET not POST #3483

bmckinney opened this issue Nov 18, 2016 · 3 comments

Comments

@bmckinney
Copy link
Contributor

bmckinney commented Nov 18, 2016

  • Docs indicate POST but code specifies GET:

    @get
    @path("{id}/actions/:publish")
    public Response publishDataset( @PathParam("id") String id, @QueryParam("type") String type ) {

  • Inconsistent with publishing a dataverse, which does indeed use POST

@pdurbin
Copy link
Member

pdurbin commented Nov 19, 2016

@bmckinney yes, assuming this issue is a duplicate of #2431 this is something that drives me crazy. Well crazier. 😄

@pdurbin
Copy link
Member

pdurbin commented Dec 22, 2016

Fixed in pull request #3550. Passing to Code Review at https://waffle.io/IQSS/dataverse

@pdurbin pdurbin removed their assignment Dec 22, 2016
@raprasad raprasad removed their assignment Jan 3, 2017
@kcondon
Copy link
Contributor

kcondon commented Jan 13, 2017

Duplicate of #2431. Closing

@kcondon kcondon closed this as completed Jan 13, 2017
@kcondon kcondon self-assigned this Jan 13, 2017
kcondon added a commit that referenced this issue Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants