Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Github actions so they are triggered from opening a Pull Request #398

Closed
ekraffmiller opened this issue May 17, 2024 · 2 comments · Fixed by #401
Closed

update Github actions so they are triggered from opening a Pull Request #398

ekraffmiller opened this issue May 17, 2024 · 2 comments · Fixed by #401
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. tests Add or improve existing tests

Comments

@ekraffmiller
Copy link
Contributor

When contributors open a PR, it would be helpful to have all the same tests run that we currently have for pushing commits

@ekraffmiller ekraffmiller added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows tests Add or improve existing tests labels May 17, 2024
@ekraffmiller ekraffmiller moved this to This Sprint 🏃‍♀️ 🏃 in IQSS Dataverse Project May 17, 2024
@pdurbin
Copy link
Member

pdurbin commented May 20, 2024

If it helps, @poikilotherm created a detailed diagram about how GitHub Actions are configured with external contributors in mind for the main "dataverse" repo:

Image

The pull request hasn't been merged yet:

To see the diagram in context: https://dataverse-guide--9776.org.readthedocs.build/en/9776/container/auto-usage.html

@ekraffmiller
Copy link
Contributor Author

ekraffmiller commented May 20, 2024

https://dataverse-guide--9776.org.readthedocs.build/en/9776/container/auto-usage.html

@pdurbin It looks like this uses the access to secrets to control the actions triggered by external contributors. Based on our conversation at standup, I don't think we will need to do this, we'll just follow the restrictions set at the IQSS level
(https://github.com/organizations/IQSS/settings/actions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. tests Add or improve existing tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants