Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US_UtilityNetwork_authorityRole RelatedParty type to reference inline #83

Closed
mquanz opened this issue Jan 4, 2024 · 3 comments · Fixed by #86
Closed

US_UtilityNetwork_authorityRole RelatedParty type to reference inline #83

mquanz opened this issue Jan 4, 2024 · 3 comments · Fixed by #86
Labels
breaking change The change proposal prevents backward compatibility of the schema for JRC The change proposal is to be implemented by the JRC.
Milestone

Comments

@mquanz
Copy link

mquanz commented Jan 4, 2024

Change proposal description

In the "UtilityNetwork" FeatureType (application scheme "Common Utility Network Elements") the data type of "authorityRole" is defined by the implementation rules and INSPIRE model as "RelatedParty". This is implemented in the INSPIRE schema XSD in form of a gml:ReferenceType.

Extract from the XSD:
<element maxOccurs="unbounded" name="authorityRole" type="gml:ReferenceType">

However a reference can only be set to a feature type, not to a data type. As it is not possible to create a RelatedParty object on top level in a gml:FeatureCollection, this is indeed a problem.

I suggest to change the schema that RelatedParty objects can be created inline.

Issue faced

RelatedParty objects cannot be referenced.

Expected behaviour

RelatedParty objects can be created inline.

Current behaviour

RelatedParty objects cannot be referenced.

Proposed solution

I suggest to change the schema that RelatedParty objects can be created inline.

Additional information

Proposal reason

This change proposal is needed because the schema model does not fit the purpose.

Addressed schema

us-net-common

Impact on INSPIRE TG / IR

Change proposer

Martin Quanz

References

Available implementation

More detailed documentation

@fabiovinci
Copy link
Collaborator

Dear @mquanz,

thank you for opening the issue.
It seems that the datatype of the "authorityRole" attribute is not correct.
We will have a look asap.

@fabiovinci fabiovinci added the for Sub-group The change proposal is to be assessed by the Sub-group label Jan 8, 2024
@sMorrone sMorrone added the breaking change The change proposal prevents backward compatibility of the schema label Jan 17, 2024
@sMorrone
Copy link
Collaborator

Just adding details of required schema change:
current definition
<element maxOccurs="unbounded" name="authorityRole" type="gml:ReferenceType">
should be replaced by

<element maxOccurs="unbounded" name="authorityRole">
         <complexType>
            <sequence>
              <element ref="base2:RelatedParty"/>
            </sequence>
         </complexType>
  </element>

@fabiovinci
Copy link
Collaborator

The sub-group approved this change proposal after consultation by email.
Since it was classified as a "trivial change", it can be directly implemented by JRC.

@fabiovinci fabiovinci added for JRC The change proposal is to be implemented by the JRC. and removed for Sub-group The change proposal is to be assessed by the Sub-group labels Feb 6, 2024
@fabiovinci fabiovinci added this to the 2024.1 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The change proposal prevents backward compatibility of the schema for JRC The change proposal is to be implemented by the JRC.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants