bug in getType of X.class when X is primitive

[monperrus]

"short.class".getType().isPrimitive() returns true, it should return false because it is a Class object

same bug for int.class, etc.

[GerardPaligot]

What is "short.class"?

[monperrus]

Here is the expected behavior

        Factory factory = TestUtils.createFactory();
        CtClass<?> clazz = factory
                .Code()
                .createCodeSnippetStatement(
                        "" + "class X {" + "public void foo() {"
                                + " Class klass=null;"
                                + "  boolean x= (klass == short.class);"
                                + "}};")
                .compile();
        CtMethod<?> foo = (CtMethod<?>) clazz.getMethods().toArray()[0];

        CtBlock<?> body = foo.getBody();
        CtLocalVariable<?> ass = body.getStatement(1);
        CtBinaryOperator<?> op = (CtBinaryOperator<?>) ass.getDefaultExpression();      
        assertEquals("Class", op.getLeftHandOperand().getType().getSimpleName());
        assertFalse(op.getLeftHandOperand().getType().isPrimitive());
        assertEquals("Class", op.getRightHandOperand().getType().getSimpleName());
        assertFalse(op.getRightHandOperand().getType().isPrimitive());

[monperrus]

Slightly modified the test case

it's fun, #349, #346 and this one are actually quite related